-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util: make debuglog show up in --inspect logs #41884
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the TODO LGTM (it already doesn't matter now that we snapshot the console methods) , but I have a question regarding the implementation of the wrapping
af442bd
to
fdb31dd
Compare
@addaleax I've pulled out the console changes for now. Would it be fine to have these as a separate PR still? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be fine to have these as a separate PR still?
I think so -- it's definitely a breaking change, though. (This PR doesn't need to be semver-major anymore imo.)
@bmeck Ping. Are we planning to get this to a closure? |
This needs a rebase. |
This makes
util.debuglog()
show up in the inspector console under thedebug
level.@joyeecheung I've removed the TODO comment since it loses data prior to connection of an inspector which is a UX degradation from the existing situation and doesn't match other environments for JS.
This does cause the same kind of memory leak while retaining messages as
console
currently does but it only does so if the specificdebuglog
set is enabled.