Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix tls-inception #4195

Closed
wants to merge 2 commits into from
Closed

test: fix tls-inception #4195

wants to merge 2 commits into from

Conversation

santigimeno
Copy link
Member

Make sure all the data is read before checking its validity.
Remove gotHello variable and just check that the ssl end event
is received.

/cc @indutny

@santigimeno santigimeno mentioned this pull request Dec 8, 2015
Closed
@JungMinu JungMinu added the test Issues and PRs related to the tests. label Dec 8, 2015
@mscdex mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 8, 2015
mscdex
mscdex reviewed Dec 8, 2015
View reviewed changes
test/parallel/test-tls-inception.js
@@ -13,7 +13,6 @@ var path = require('path');
var net = require('net');

var options, a, b, portA, portB;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW portA and portB can be removed too, they're not used.

@mscdex
Copy link
Contributor

mscdex commented Dec 8, 2015

LGTM

@indutny
Copy link
Member

indutny commented Dec 8, 2015

One nit from @mscdex , otherwise LGTM. Thanks!

@santigimeno
test: fix tls-inception
89ff7dd 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.
@santigimeno
test: fix tls-inception flakiness
432a86e 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.
@santigimeno
Copy link
Member Author

Updated the PR removing the unused variables.

I have also added a fix for the problems reported here #1012 (comment). I have sent this in a separate commit. Is this correct? or should I squash both commits into a single one? or a different PR?

/cc @indutny @mscdex

indutny
indutny reviewed Dec 9, 2015
View reviewed changes
test/parallel/test-tls-inception.js

var body = new Buffer(4000).fill('A');
var body = new Buffer(400000).fill('A');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit over the top, probably? What do you think about a compromise with a 40000?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used that value to reproduce the ECONNRESET error in OS X consistently.

@indutny
Copy link
Member

indutny commented Dec 10, 2015

LGTM, thank you!

@indutny
Copy link
Member

indutny commented Dec 10, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/972/

@indutny
Copy link
Member

indutny commented Dec 10, 2015

Unrelated test failures, landing!

@indutny
Copy link
Member

indutny commented Dec 10, 2015

Landed in 86a3bd0 and 3b94991. Thank you!

@indutny indutny closed this Dec 10, 2015
indutny pushed a commit that referenced this pull request Dec 10, 2015
@santigimeno @indutny
test: fix tls-inception
86a3bd0 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
indutny pushed a commit that referenced this pull request Dec 10, 2015
@santigimeno @indutny
test: fix tls-inception flakiness
3b94991 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@santigimeno santigimeno deleted the tls_inception branch December 10, 2015 09:26
@santigimeno
Copy link
Member Author

Thanks

@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
Closed
cjihrig pushed a commit that referenced this pull request Dec 15, 2015
@santigimeno @cjihrig
test: fix tls-inception
9b44d49 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
cjihrig pushed a commit that referenced this pull request Dec 15, 2015
@santigimeno @cjihrig
test: fix tls-inception flakiness
d5ac6ce 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
Closed
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
@santigimeno
test: fix tls-inception
a1f7bc7 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Dec 30, 2015
@santigimeno
test: fix tls-inception flakiness
76f5a91 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@santigimeno
test: fix tls-inception
c41b280 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@santigimeno
test: fix tls-inception flakiness
d00b9fc 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: #4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
@santigimeno santigimeno mentioned this pull request Feb 24, 2016
Closed
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@santigimeno
test: fix tls-inception
d722b38 
Make sure all the data is read before checking its validity.
Remove `gotHello` variable and just check that the ssl `end` event
is received.
Remove unused variables.

PR-URL: nodejs#4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@santigimeno
test: fix tls-inception flakiness
7a402e4 
When sending a very large buffer (400000 bytes) the test fails due to
the client socket from the `a` server erroring with `ECONNRESET`.
There's a race condition between the closing of this socket and the `ssl`
socket closing on the other side of the connection. To improve things,
destroy the socket as soon as possible: in the `end` event of the `dest`
socket.

PR-URL: nodejs#4195
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
jBarz added a commit to ibmruntimes/node that referenced this pull request Feb 19, 2017
@jBarz
test: fix tls-inception flakiness
6b68c09 
cherry-picked the following from master

commit 3b94991
Author: Santiago Gimeno <santiago.gimeno@gmail.com>
Date:   Tue Dec 8 14:57:22 2015 +0100

    test: fix tls-inception flakiness

    When sending a very large buffer (400000 bytes) the test fails due
    to the client socket from the `a` server erroring with `ECONNRESET`.
    There's a race condition between the closing of this socket and the
    `ssl` socket closing on the other side of the connection. To improve
    things, destroy the socket as soon as possible: in the `end` event
    of the `dest` socket.

    PR-URL: nodejs/node#4195
    Reviewed-By: Brian White <mscdex@mscdex.net>
    Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@santigimeno @mscdex @indutny @jasnell @MylesBorins @JungMinu