test: fix tls-inception #4195
Closed
test: fix tls-inception #4195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,6 @@ var path = require('path'); | |||
| var net = require('net'); | |||
|
|
|||
| var options, a, b, portA, portB; | |||
There was a problem hiding this comment.
FWIW portA and portB can be removed too, they're not used.
|
LGTM |
|
One nit from @mscdex , otherwise LGTM. Thanks! |
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables.
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket.
santigimeno
force-pushed
the
tls_inception
branch
from
6929fc3 to
432a86e
Compare
|
Updated the PR removing the unused variables. I have also added a fix for the problems reported here #1012 (comment). I have sent this in a separate commit. Is this correct? or should I squash both commits into a single one? or a different PR? |
|
|
||
| var body = new Buffer(4000).fill('A'); | ||
| var body = new Buffer(400000).fill('A'); |
There was a problem hiding this comment.
I think this is a bit over the top, probably? What do you think about a compromise with a 40000?
There was a problem hiding this comment.
I've used that value to reproduce the ECONNRESET error in OS X consistently.
|
LGTM, thank you! |
|
Unrelated test failures, landing! |
indutny
pushed a commit
that referenced
this pull request
Dec 10, 2015
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
indutny
pushed a commit
that referenced
this pull request
Dec 10, 2015
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
|
Thanks |
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: #4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Make sure all the data is read before checking its validity. Remove `gotHello` variable and just check that the ssl `end` event is received. Remove unused variables. PR-URL: nodejs#4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: nodejs#4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
jBarz
added a commit
to ibmruntimes/node
that referenced
this pull request
Feb 19, 2017
cherry-picked the following from master commit 3b94991 Author: Santiago Gimeno <santiago.gimeno@gmail.com> Date: Tue Dec 8 14:57:22 2015 +0100 test: fix tls-inception flakiness When sending a very large buffer (400000 bytes) the test fails due to the client socket from the `a` server erroring with `ECONNRESET`. There's a race condition between the closing of this socket and the `ssl` socket closing on the other side of the connection. To improve things, destroy the socket as soon as possible: in the `end` event of the `dest` socket. PR-URL: nodejs/node#4195 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure all the data is read before checking its validity.
Remove
gotHellovariable and just check that the sslendeventis received.
/cc @indutny