Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: make node-gyp work again on windows #422

Merged
merged 1 commit into from
Jan 15, 2015
Merged

deps: make node-gyp work again on windows #422

merged 1 commit into from
Jan 15, 2015

Conversation

piscisaureus
Copy link
Contributor

  • Fetch from the correct url.
  • use iojs.lib instead of node.lib.
  • Disable checksum checks for iojs.lib until our website supports them.

R=@bnoordhuis
R=@rvagg

@piscisaureus piscisaureus mentioned this pull request Jan 14, 2015
Closed
@piscisaureus
Copy link
Contributor Author

cc @seishun

@bnoordhuis
Copy link
Member

LGTM if it works but it would be nice if you undid some of the renames. All of the changes have to be upstreamed eventually and the smaller the diff is, the easier.

@rvagg
Copy link
Member

rvagg commented Jan 14, 2015

ditto @bnoordhuis, lgtm but we really need to upstream this

@piscisaureus
Copy link
Contributor Author

@bnoordhuis @rvagg This better?

@bnoordhuis
Copy link
Member

LGTM

@rvagg
Copy link
Member

rvagg commented Jan 15, 2015

yes, good enough, land this and then one of us needs to take responsibility for proposing an upstream patch to make this permanent and portable

@piscisaureus
deps: make node-gyp work again on windows
5de334c 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: nodejs#422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
@piscisaureus piscisaureus merged commit 5de334c into nodejs:v1.x Jan 15, 2015
@piscisaureus piscisaureus deleted the win-fix-node-gyp branch January 15, 2015 00:40
othiym23 pushed a commit to npm/node that referenced this pull request Jan 18, 2015
@piscisaureus @othiym23
deps: make node-gyp work again on windows
ccfd022 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: nodejs#422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
piscisaureus added a commit that referenced this pull request Jan 18, 2015
@piscisaureus @bnoordhuis
deps: make node-gyp work again on windows
1952219 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: #422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
piscisaureus added a commit that referenced this pull request Jan 23, 2015
@piscisaureus @bnoordhuis
deps: make node-gyp work again on windows
8b55048 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: #422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Jan 30, 2015
@piscisaureus @othiym23
deps: make node-gyp work again on windows
f8ca6f0 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: nodejs#422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
@Fishrock123 Fishrock123 mentioned this pull request Jan 30, 2015
Closed
piscisaureus added a commit that referenced this pull request Jan 31, 2015
@piscisaureus @bnoordhuis
deps: make node-gyp work again on windows
bce7a26 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: #422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Feb 6, 2015
@piscisaureus @othiym23
deps: make node-gyp work again on windows
d2a654d 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: nodejs#422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
piscisaureus added a commit that referenced this pull request Feb 6, 2015
@piscisaureus @bnoordhuis
deps: make node-gyp work again on windows
7a301e2 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: #422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
othiym23 pushed a commit to npm/node that referenced this pull request Feb 20, 2015
@piscisaureus @othiym23
deps: make node-gyp work again on windows
a652e32 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: nodejs#422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
piscisaureus added a commit that referenced this pull request Feb 22, 2015
@piscisaureus @bnoordhuis
deps: make node-gyp work again on windows
97b4243 
* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: #422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
@cjihrig cjihrig mentioned this pull request Feb 27, 2015
Closed
This was referenced Oct 25, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 1, 2022
Open
This was referenced Jan 21, 2023
Open
Open
@ashly1111111 ashly1111111 mentioned this pull request Aug 21, 2023
Open
@JCsomeShots JCsomeShots mentioned this pull request Sep 19, 2023
Open
@kingjay66 kingjay66 mentioned this pull request Oct 15, 2023
Open
@NOUIY NOUIY mentioned this pull request Oct 19, 2023
Open
@ashly1111111 ashly1111111 mentioned this pull request Oct 19, 2023
Open
@NOUIY NOUIY mentioned this pull request Nov 2, 2023
Open
@ashly1111111 ashly1111111 mentioned this pull request Nov 2, 2023
Open
@Jingyi090 Jingyi090 mentioned this pull request Nov 17, 2023
Open
@nickfnblum nickfnblum mentioned this pull request Nov 21, 2023
Open
@NOUIY NOUIY mentioned this pull request Nov 23, 2023
Open
@ashly1111111 ashly1111111 mentioned this pull request Nov 24, 2023
Open
@aravindb26 aravindb26 mentioned this pull request Jan 4, 2024
Open
@CxsLucyfer CxsLucyfer mentioned this pull request Jan 29, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Feb 6, 2024
Open
@jefeaguila jefeaguila mentioned this pull request Feb 11, 2024
Open
@ahamedislam ahamedislam mentioned this pull request Feb 22, 2024
Open
@DanyRay420 DanyRay420 mentioned this pull request Feb 24, 2024
Open
@Jircs1 Jircs1 mentioned this pull request Mar 18, 2024
Open
@08epouu1 08epouu1 mentioned this pull request Mar 20, 2024
Open
@matrix-compute matrix-compute mentioned this pull request Mar 28, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Mar 29, 2024
Open
@lairortega lairortega mentioned this pull request Apr 14, 2024
Open
@SherfeyInv SherfeyInv mentioned this pull request Apr 17, 2024
Merged
@dannybrown13 dannybrown13 mentioned this pull request May 7, 2024
Open
@CharliesAngel1 CharliesAngel1 mentioned this pull request May 7, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request May 10, 2024
Open
@paaschdigital paaschdigital mentioned this pull request May 20, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 21, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Oct 13, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piscisaureus @bnoordhuis @rvagg