Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to provide an alternative to
crypto.Hash
andcrypto.webcrypto.subtle.digest
that is faster and simpler to use.crypto.Hash
is much faster thancrypto.webcrypto.subtle.digest
according tobenchmark/crypto/oneshot-hash.js
:The current implementation of
crypto.hash
is about 20 percent faster thancrypto.Hash
for data smaller than 1 KiB:There is still room for improvement. For example, it still unnecessarily calls into C++ twice.
One thing I am not sure about is encoding. I think an additional
encoding
parameter for the output would make sense, since producinghex
or evenbase64
digests is extremely common. That leaves no room for an input encoding, which is why strings are currently not allowed as inputs.We can also add a
callback
argument (similar tocrypto.sign
in #26611).Refs: #26748