Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for extracting function name in inspect_repl.js #42399

Merged
merged 1 commit into from
May 1, 2022

Conversation

cola119
Copy link
Member

@cola119 cola119 commented Mar 19, 2022

This PR adds test for extractFunctionName function in lib/internal/debugger/inspect_repl.js and improves code coverage. That function previously was untested. ref
I found some issues serializing a function name. I'll fix them in other PR.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 19, 2022
Comment on lines +22 to +23
.then(() => cli.command('exec a = function func () {}; a;'))
.then(() => assert.match(cli.output, /\[Function\]/))
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current logic seems to not consider white spaces between function name and brackets.

@cola119
Copy link
Member Author

cola119 commented Apr 30, 2022

@Trott @jasnell Sorry for bothering you. May I ask when this PR will get landed? I'd like to work on some tasks depending on this change.

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 1, 2022
@nodejs-github-bot nodejs-github-bot merged commit d268cf5 into nodejs:master May 1, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d268cf5

@cola119 cola119 deleted the test-debugger-func-name branch May 1, 2022 04:24
targos pushed a commit that referenced this pull request May 2, 2022
PR-URL: #42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants