Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: introduce secureContext for tls.connect #4246

Closed
wants to merge 1 commit into from
Closed

tls: introduce secureContext for tls.connect #4246

wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Dec 11, 2015

Add secureContext option to tls.connect. It is useful for caching
client certificates, key, and CA certificates.

cc @nodejs/crypto

@indutny
tls: introduce secureContext for tls.connect
3033e51 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.
@indutny indutny added tls Issues and PRs related to the tls subsystem. semver-minor PRs that contain new features and should be released in the next minor version. labels Dec 11, 2015
@indutny
Copy link
Member Author

indutny commented Dec 11, 2015

CI: https://ci.nodejs.org/job/node-test-pull-request/979/

@indutny
Copy link
Member Author

indutny commented Dec 11, 2015

the next step would probably be adding secureContext caching to https.Agent

@jasnell
Copy link
Member

jasnell commented Dec 11, 2015

LGTM

@indutny
Copy link
Member Author

indutny commented Dec 12, 2015

Thank you!

@indutny
Copy link
Member Author

indutny commented Dec 12, 2015

Landed in c5b4f6b, thanks again!

@indutny indutny closed this Dec 12, 2015
@indutny indutny deleted the feature/tls-connect-secure-context branch December 12, 2015 00:54
indutny added a commit that referenced this pull request Dec 12, 2015
@indutny
tls: introduce secureContext for tls.connect
c5b4f6b 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell <jasnell@gmail.com>
@tlivings
Copy link

This is so exciting.

@Fishrock123 Fishrock123 mentioned this pull request Dec 15, 2015
Closed
indutny added a commit that referenced this pull request Dec 15, 2015
@indutny @cjihrig
tls: introduce secureContext for tls.connect
5daa711 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell <jasnell@gmail.com>
AdriVanHoudt added a commit to AdriVanHoudt/node that referenced this pull request Dec 17, 2015
@AdriVanHoudt
doc: improve grammar in tls docs
10f6acf 
Fix: nodejs#4246
PR-URL: nodejs#4315
jasnell pushed a commit that referenced this pull request Dec 24, 2015
@AdriVanHoudt @jasnell
doc: improve grammar in tls docs
2fd3d8a 
Fix: #4246
PR-URL: #4315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@AdriVanHoudt @Fishrock123
doc: improve grammar in tls docs
6450d86 
Fix: nodejs#4246
PR-URL: nodejs#4315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@indutny
tls: introduce secureContext for tls.connect
8e0c4e9 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: nodejs#4246
Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@AdriVanHoudt
doc: improve grammar in tls docs
fb56a3a 
Fix: nodejs#4246
PR-URL: nodejs#4315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@indutny
Copy link
Member Author

indutny commented Sep 27, 2016

@thealphanerd can we backport it to v4? Or is it too late?

@MylesBorins
Copy link
Contributor

@indutny I've added this to the LTS agenda and we can discuss having this added in a future minor release of v4. It will be important to collect some information about why this is important to be in v4

@indutny
Copy link
Member Author

indutny commented Sep 27, 2016

Thanks!

@indutny
Copy link
Member Author

indutny commented Sep 27, 2016

@thealphanerd this is pretty important for PayPal, since it will save tons of CPU and memory.

@tlivings
Copy link

Yes - we will be on node 4 for at least 6 more months and TLS performance is critical.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 27, 2016

Looks like a clean and purely additive change to me, so +1 for backporting in the next semver-minor if that feature is wanted in v4.x.

@indutny
Copy link
Member Author

indutny commented Sep 27, 2016

+1 from me, if it matters 💃

@indutny indutny mentioned this pull request Sep 28, 2016
Closed
@MylesBorins MylesBorins mentioned this pull request Sep 30, 2016
Closed
@MylesBorins
Copy link
Contributor

the LTS working group has discussed this change and agreed to land it in an upcoming v4.x release

@indutny do you want to take the lead on the backport?

@indutny
Copy link
Member Author

indutny commented Oct 4, 2016

@thealphanerd absolutely, should I open PR for v4.x-staging?

@indutny indutny mentioned this pull request Oct 6, 2016
Closed
4 tasks
@MylesBorins MylesBorins added this to the v4.7.0 milestone Oct 24, 2016
indutny added a commit to indutny/io.js that referenced this pull request Oct 24, 2016
@indutny
tls: introduce secureContext for tls.connect
125977b 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: nodejs#4246
Reviewed-By: James M Snell <jasnell@gmail.com>
indutny added a commit that referenced this pull request Oct 27, 2016
@indutny
tls: introduce secureContext for tls.connect
d9b5437 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 8, 2016
@indutny
tls: introduce secureContext for tls.connect
9049c1f 
Add `secureContext` option to `tls.connect`. It is useful for caching
client certificates, key, and CA certificates.

PR-URL: #4246
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins removed this from the 4.7.0 milestone Nov 14, 2016
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 4.7.0 'Argon' (LTS)
f4f2bce 
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 4.7.0 'Argon' (LTS)
4e73e75 
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 4.7.0 'Argon' (LTS)
6ade6de 
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    #7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) #3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) #7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) #4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) #4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    #6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) #8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9736
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
@imyller
2016-12-06, Version 4.7.0 'Argon' (LTS)
72bbc64 
    This LTS release comes with 108 commits. This includes 30 which are doc
    related, 28 which are test related, 16 which are build / tool related,
    and 4 commits which are updates to dependencies.

    Notable Changes:

    The SEMVER-MINOR changes include:

    * build:
      - export openssl symbols on Windows making it possible to build
        addons linked against the bundled version of openssl (Alex Hultman)
        nodejs/node#7576
    * debugger:
      - make listen address configurable in the debugger server
        (Ben Noordhuis) nodejs/node#3316
    * dgram:
      - generalized send queue to handle close fixing a potential throw
        when dgram socket is closed in the listening event handler.
        (Matteo Collina) nodejs/node#7066
    * http:
      - Introduce the 451 status code "Unavailable For Legal Reasons"
        (Max Barinov) nodejs/node#4377
    * tls:
      - introduce `secureContext` for `tls.connect` which is useful for
        caching client certificates, key, and CA certificates.
        (Fedor Indutny) nodejs/node#4246

    Notable SEMVER-PATCH changes include:

    * build:
      - introduce the configure --shared option for embedders (sxa555)
        nodejs/node#6994
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * src:
      - node no longer aborts when c-ares initialization fails
        (Ben Noordhuis) nodejs/node#8710
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9736

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
@imyller
2016-12-06, Version 4.7.0 'Argon' (LTS)
3a81f72 
    This LTS release comes with 108 commits. This includes 30 which are doc
    related, 28 which are test related, 16 which are build / tool related,
    and 4 commits which are updates to dependencies.

    Notable Changes:

    The SEMVER-MINOR changes include:

    * build:
      - export openssl symbols on Windows making it possible to build
        addons linked against the bundled version of openssl (Alex Hultman)
        nodejs/node#7576
    * debugger:
      - make listen address configurable in the debugger server
        (Ben Noordhuis) nodejs/node#3316
    * dgram:
      - generalized send queue to handle close fixing a potential throw
        when dgram socket is closed in the listening event handler.
        (Matteo Collina) nodejs/node#7066
    * http:
      - Introduce the 451 status code "Unavailable For Legal Reasons"
        (Max Barinov) nodejs/node#4377
    * tls:
      - introduce `secureContext` for `tls.connect` which is useful for
        caching client certificates, key, and CA certificates.
        (Fedor Indutny) nodejs/node#4246

    Notable SEMVER-PATCH changes include:

    * build:
      - introduce the configure --shared option for embedders (sxa555)
        nodejs/node#6994
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * src:
      - node no longer aborts when c-ares initialization fails
        (Ben Noordhuis) nodejs/node#8710
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9736

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-minor PRs that contain new features and should be released in the next minor version. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@indutny @jasnell @tlivings @MylesBorins @ChALkeR