Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: pass data into napi_create_external #42532

Merged
merged 1 commit into from
Apr 2, 2022

Commits on Mar 30, 2022

  1. test: pass data into napi_create_external

    Since v8 10.1 v8::External::New DCHECKs that the data passed
    into it cannot be a nullptr because that's not serializable
    as external references. This updates the test to pass a
    dummy data pointer to the call - which does not matter for the
    test since we only care about whether the finalizer is
    called.
    
    Refs: https://chromium-review.googlesource.com/c/v8/v8/+/3513234
    joyeecheung committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    c3da39f View commit details
    Browse the repository at this point in the history