Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: aes webcrypto unwrap is not a node-specific extensions #42561

Merged
merged 1 commit into from
Apr 3, 2022
Merged

doc: aes webcrypto unwrap is not a node-specific extensions #42561

merged 1 commit into from
Apr 3, 2022

Conversation

panva
Copy link
Member

@panva panva commented Apr 1, 2022

'AES-CTR', 'AES-CBC', 'AES-GCM', and 'AES-KW' are regular SubtleCrypto.unwrapKey algorithm, not node-specific extensions

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 1, 2022
@panva panva added the webcrypto label Apr 1, 2022
@panva panva requested a review from jasnell April 1, 2022 10:19
tniessen
tniessen approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I correct to assume that this is because of this step in unwrapKey?

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

@panva
Copy link
Member Author

panva commented Apr 1, 2022

Am I correct to assume that this is because of this step in unwrapKey?

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

Yeah, that's the beginning of it.

https://w3c.github.io/webcrypto/#SubtleCrypto-method-unwrapKey

If an error occurred, let normalizedAlgorithm be the result of normalizing an algorithm, with alg set to algorithm and op set to "decrypt".

which then leads to

Otherwise, if normalizedAlgorithm supports a decrypt operation:
Let key be the result of performing the decrypt operation specified by normalizedAlgorithm using algorithm, unwrappingKey as key and wrappedKey as ciphertext.

Screenshot 2022-04-01 at 12 53 21

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 1, 2022
@panva panva added experimental Issues and PRs related to experimental features. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 2, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2022
@nodejs-github-bot nodejs-github-bot merged commit e12cfd8 into nodejs:master Apr 3, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in e12cfd8

@panva panva deleted the doc-fix-webcrypto branch April 3, 2022 10:11
juanarbol pushed a commit to juanarbol/node that referenced this pull request Apr 5, 2022
@panva @juanarbol
doc: aes webcrypto unwrap is not a node-specific extensions
a6c65fc 
PR-URL: nodejs#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Apr 5, 2022
Closed
Merged
juanarbol pushed a commit that referenced this pull request Apr 6, 2022
@panva @juanarbol
doc: aes webcrypto unwrap is not a node-specific extensions
71ab0de 
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@panva @xtx1130
doc: aes webcrypto unwrap is not a node-specific extensions
b51d7cb 
PR-URL: nodejs#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@panva @juanarbol
doc: aes webcrypto unwrap is not a node-specific extensions
1b8cc7b 
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@panva @danielleadams
doc: aes webcrypto unwrap is not a node-specific extensions
5c384f6 
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@panva @targos
doc: aes webcrypto unwrap is not a node-specific extensions
473240c 
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@panva @targos
doc: aes webcrypto unwrap is not a node-specific extensions
5ee6b07 
PR-URL: #42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@panva @guangwong
doc: aes webcrypto unwrap is not a node-specific extensions
b2f8751 
PR-URL: nodejs/node#42561
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @Trott @tniessen