-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add note about header values encoding #42624
Conversation
Review requested:
|
Fast-track has been requested by @ShogunPanda. Please 👍 to approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 I see the commit label since this morning. Is the commit queue stuck? If that's the case I'll land this tomorrow from if you and other collaborators +1 the fast track. |
The
commit-queue-squash
node/doc/contributing/commit-queue.md Lines 40 to 41 in a199387
Only the
commit-queue
node/doc/contributing/commit-queue.md Lines 18 to 22 in a199387
You should keep
commit-queue-squash
|
I see. Actually I was planning to land it manually using Do you mind approving it so the tool will not complain of commits after latest approvals? |
Landed in dfc2dc8 |
PR-URL: nodejs#42624 Fixes: nodejs#42579 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#42624 Fixes: nodejs/node#42579 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This PR add a note about
http.Outgoing.setHeader
.At the moment, if the user use
.setHeader(name, value)
and value contains non latin1 characters, then method will throw an exception. But this is not documented anywhere.Additionally it also suggests to use RFC8187 standard when UTF-8 values must be passed (rather than arbitrarily convert those values to latin1 as suggested on the net).
Fixes: #42579