Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add NodeEdKeyGenParams to CryptoKey.algorithm #42629

Merged
merged 1 commit into from
Apr 13, 2022
Merged

doc: add NodeEdKeyGenParams to CryptoKey.algorithm #42629

merged 1 commit into from
Apr 13, 2022

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Apr 6, 2022

Example of a CryptoKey whose algorithm is a NodeEdKeyGenParams object:

const { publicKey } = await crypto.webcrypto.subtle.generateKey({
  name: 'NODE-ED25519',
  namedCurve: 'NODE-ED25519'
}, true, ['sign']);
console.log(publicKey.algorithm);

@tniessen tniessen requested a review from panva April 6, 2022 20:29
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Apr 6, 2022
panva
panva approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@panva panva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing to rebase for in #42507 ;)

@tniessen
Copy link
Member Author

tniessen commented Apr 6, 2022

@panva Ah sorry, I didn't compare with #42507 before opening this.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2022
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2022
@nodejs-github-bot nodejs-github-bot merged commit f825341 into nodejs:master Apr 13, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f825341

vmoroz pushed a commit to vmoroz/node that referenced this pull request Apr 13, 2022
@tniessen @vmoroz
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
52ab23b 
PR-URL: nodejs#42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@tniessen @xtx1130
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
7b15545 
PR-URL: nodejs#42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
58d737c 
PR-URL: #42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@tniessen @danielleadams
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
52ad445 
PR-URL: #42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@tniessen @targos
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
5ca0720 
PR-URL: #42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
654e71c 
PR-URL: #42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
doc: add NodeEdKeyGenParams to CryptoKey.algorithm
8fa9e60 
PR-URL: nodejs/node#42629
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tniessen @nodejs-github-bot @panva @jasnell