[v14.x] deps: backport v8 367b0c1e #42637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
|
The commit msg not meet v8 cherrypick requiments, consider using https://github.com/nodejs/node-core-utils/ |
Original commit message:
[runtime] Change default scope info for SyntheticFunctionContexts
This changes the default scope info for SyntheticFunctionContexts
to the EmptyScopeInfo which does not contain an extension slot.
The bug happened because, previously, the native context scope info
was used as dummy.
Change-Id: I4d6bf6918c11c79201d16bde99ed76800ad6f6c5
Bug: v8:10629
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277806
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68636}
Refs: v8/v8@367b0c1
|
@gengjiawen thank you for the suggestion. I was following the pattern of #37864. Seems we have a new way to do it. Updated :) |
gengjiawen
approved these changes
Apr 7, 2022
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
22 tasks
targos
approved these changes
Apr 8, 2022
richardlau
approved these changes
Apr 8, 2022
This was referenced Apr 9, 2022
juanarbol
pushed a commit
that referenced
this pull request
Apr 28, 2022
Original commit message:
[runtime] Change default scope info for SyntheticFunctionContexts
This changes the default scope info for SyntheticFunctionContexts
to the EmptyScopeInfo which does not contain an extension slot.
The bug happened because, previously, the native context scope info
was used as dummy.
Change-Id: I4d6bf6918c11c79201d16bde99ed76800ad6f6c5
Bug: v8:10629
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277806
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68636}
Refs: v8/v8@367b0c1
PR-URL: #42637
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
|
Thankss! Landed in b52a268 🎉 |
juanarbol
added a commit
that referenced
this pull request
Apr 28, 2022
Notable changes V8: V8 had a stack overflow issue affecting the `vm` module, cherry-picking `941b023 from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting v8/v8@367b0c1 from V8. Learn more at: #42637 Contributed by Gabriel Schulhof (@legendecas) PR-url: TBD
Merged
juanarbol
pushed a commit
that referenced
this pull request
May 1, 2022
Original commit message:
[runtime] Change default scope info for SyntheticFunctionContexts
This changes the default scope info for SyntheticFunctionContexts
to the EmptyScopeInfo which does not contain an extension slot.
The bug happened because, previously, the native context scope info
was used as dummy.
Change-Id: I4d6bf6918c11c79201d16bde99ed76800ad6f6c5
Bug: v8:10629
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2277806
Commit-Queue: Victor Gomes <victorgomes@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Auto-Submit: Victor Gomes <victorgomes@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68636}
Refs: v8/v8@367b0c1
PR-URL: #42637
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 1, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v16.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 2, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (941b023) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas)
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by @devsnek * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (@bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (@ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (@devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (@legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 3, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 4, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
juanarbol
added a commit
that referenced
this pull request
May 4, 2022
Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42558
Backport https://chromium-review.googlesource.com/c/v8/v8/+/2277806