test: improve observable ICU behaviour coverage #42683

LiviaMedeiros · 2022-04-10T12:39:19Z

Test for bundled full-icu and its intergation with Node.
Starting from v70, it caches locale and ignores attempts to mutate process.env in runtime (for example, to normalize Date stringification). This test gives an example of observable results and tests if this behaviour is kept.

Tests are performed for full-icu >=71.x.

nodejs-github-bot · 2022-04-13T15:48:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43482/

Safety measure because ICU bumps are semver-patch

nodejs-github-bot · 2022-04-13T19:29:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43484/

nodejs-github-bot · 2022-04-29T11:19:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43768/

aduh95 · 2022-04-29T14:36:57Z

Related CI failures

node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected

  [
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
+   'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)'
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (中欧标准时间)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (मध्य यूरोपीय मानक समय)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (hora estándar de Europa central)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (heure normale d’Europe centrale)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (توقيت وسط أوروبا الرسمي)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (মধ্য ইউরোপীয় মানক সময়)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (Центральная Европа, стандартное время)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (Horário Padrão da Europa Central)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (وسطی یورپ کا معیاری وقت)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (Waktu Standar Eropa Tengah)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (Mitteleuropäische Normalzeit)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (中央ヨーロッパ標準時)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (Mídúl Yúrop Fíksd Taim)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (मध्‍य युरोपियन प्रमाण वेळ)',
-   'Fri Jul 25 1980 01:35:33 GMT+0100 (సెంట్రల్ యూరోపియన్ ప్రామాణిక సమయం)'
  ]
    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-icu-env.js:90:10)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)'
  ],
  expected: [
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Central European Standard Time)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (中欧标准时间)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (मध्य यूरोपीय मानक समय)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (hora estándar de Europa central)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (heure normale d’Europe centrale)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (توقيت وسط أوروبا الرسمي)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (মধ্য ইউরোপীয় মানক সময়)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Центральная Европа, стандартное время)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Horário Padrão da Europa Central)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (وسطی یورپ کا معیاری وقت)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Waktu Standar Eropa Tengah)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Mitteleuropäische Normalzeit)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (中央ヨーロッパ標準時)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (Mídúl Yúrop Fíksd Taim)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (मध्‍य युरोपियन प्रमाण वेळ)',
    'Fri Jul 25 1980 01:35:33 GMT+0100 (సెంట్రల్ యూరోపియన్ ప్రామాణిక సమయం)'
  ],
  operator: 'deepStrictEqual'
}

Node.js v19.0.0-pre

nodejs-github-bot · 2022-04-30T10:46:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43788/

LiviaMedeiros · 2022-04-30T11:09:35Z

My apologies, totally forgot to look at CI here at least once.
Mocking LANG env variable failed in

node-test-commit-custom-suites-freestyle
node-test-binary-armv7l
node-test-commit-arm
node-test-commit-linux/nodes=alpine-latest-x64
node-test-commit-linux/nodes=alpine-last-latest-x64
nonzero amount of environments where common.isOSX == true

No idea what those have in common (maybe bug, maybe some settings disallowing that, maybe they want LC_{TIME,...}/LC_ALL instead).
Added preemptive check if it works for mocking part of test.

This failure should be caused by running in Worker thread, added check for that as well.

nodejs-github-bot · 2022-05-03T17:48:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43859/

nodejs-github-bot · 2022-05-05T11:49:22Z

Landed in edcc542

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs/node#42683 Refs: nodejs/node#42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

test: improve observable ICU behaviour coverage

7516940

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 10, 2022

squash: skip tests with mocked env on OSX

a1f2973

jasnell approved these changes Apr 13, 2022

View reviewed changes

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2022

squash: skip tests if ICU is too old

cdd678d

Safety measure because ICU bumps are semver-patch

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 13, 2022

aduh95 approved these changes Apr 29, 2022

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 29, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 29, 2022

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 29, 2022

squash: add detection for unmockable env

68cac1d

github-actions bot mentioned this pull request Apr 30, 2022

CI Reliability 2022-04-30 nodejs/reliability#267

Open

27 tasks

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2022

squash: fix test in Workers

ac6e3f4

This was referenced May 1, 2022

CI Reliability 2022-05-01 nodejs/reliability#268

Open

CI Reliability 2022-05-02 nodejs/reliability#269

Open

CI Reliability 2022-05-03 nodejs/reliability#270

Open

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2022

This was referenced May 4, 2022

CI Reliability 2022-05-04 nodejs/reliability#271

Open

CI Reliability 2022-05-05 nodejs/reliability#272

Open

aduh95 approved these changes May 5, 2022

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 5, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2022

nodejs-github-bot merged commit edcc542 into nodejs:master May 5, 2022

RafaelGSS pushed a commit that referenced this pull request May 10, 2022

test: improve observable ICU behaviour coverage

e058f47

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

RafaelGSS mentioned this pull request May 10, 2022

v18.2.0 proposal #43036

Merged

juanarbol pushed a commit that referenced this pull request May 31, 2022

test: improve observable ICU behaviour coverage

38a1060

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

richardlau mentioned this pull request Jun 20, 2022

IBM i CI failures #43509

Closed

4 tasks

danielleadams pushed a commit that referenced this pull request Jun 27, 2022

test: improve observable ICU behaviour coverage

786ef96

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Jul 12, 2022

test: improve observable ICU behaviour coverage

c5a5de4

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Jul 31, 2022

test: improve observable ICU behaviour coverage

41028fb

PR-URL: #42683 Refs: #42440 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

srl295 mentioned this pull request Oct 19, 2022

deps: update ICU to 72.1 #45068

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: improve observable ICU behaviour coverage #42683

test: improve observable ICU behaviour coverage #42683

LiviaMedeiros commented Apr 10, 2022 •

edited

Loading

nodejs-github-bot commented Apr 13, 2022

nodejs-github-bot commented Apr 13, 2022

nodejs-github-bot commented Apr 29, 2022

aduh95 commented Apr 29, 2022

nodejs-github-bot commented Apr 30, 2022

LiviaMedeiros commented Apr 30, 2022 •

edited

Loading

nodejs-github-bot commented May 3, 2022

nodejs-github-bot commented May 5, 2022

test: improve observable ICU behaviour coverage #42683

test: improve observable ICU behaviour coverage #42683

Conversation

LiviaMedeiros commented Apr 10, 2022 • edited Loading

nodejs-github-bot commented Apr 13, 2022

nodejs-github-bot commented Apr 13, 2022

nodejs-github-bot commented Apr 29, 2022

aduh95 commented Apr 29, 2022

nodejs-github-bot commented Apr 30, 2022

LiviaMedeiros commented Apr 30, 2022 • edited Loading

nodejs-github-bot commented May 3, 2022

nodejs-github-bot commented May 5, 2022

LiviaMedeiros commented Apr 10, 2022 •

edited

Loading

LiviaMedeiros commented Apr 30, 2022 •

edited

Loading