Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] doc: specify flag needed for JSON modules #42735

Closed
wants to merge 1 commit into from
Closed

[v16.x] doc: specify flag needed for JSON modules #42735

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 14, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. v16.x labels Apr 14, 2022
@Trott
Copy link
Member Author

Trott commented Apr 14, 2022

I'm opening this against v16.x-staging because the flag is not required in 17.x.

@richardlau
Copy link
Member

This may be unnecessary if #42726 lands?

@Trott
Copy link
Member Author

Trott commented Apr 14, 2022

This may be unnecessary if #42726 lands?

Since that seems exceedingly likely to land, perhaps I should close this?

@aduh95 aduh95 changed the title doc: specify flag needed for JSON modules [v16.x] doc: specify flag needed for JSON modules Apr 14, 2022
@Trott Trott closed this Apr 14, 2022
@Trott Trott deleted the v16.x-esm branch September 25, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @nodejs-github-bot @richardlau