Clarify error events on HTTP module documentation #4275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
It might be worth prefixing the addition with something like "As with all |
|
Makes sense. I'll update it. |
|
LGTM |
|
Slight line wrapping nit but I'll fix that when landing... |
jasnell
pushed a commit
that referenced
this pull request
Dec 14, 2015
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Ugh.. flubbed the commit. Landed in 9538fd0 |
|
Thanks for the fast turnaround. |
cjihrig
pushed a commit
that referenced
this pull request
Dec 15, 2015
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Dec 30, 2015
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Hey @lmarkus! I believe this is your first commit to core, glad to see you got around to it! Thanks for contributing, keep up the great work @ PayPal and I hope to see your name show up more around here! |
|
Thanks @rvagg! Pretty simple as contributions go, but hopefully there will be more to come 😄 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
Make it clear that error with throw if error listener is not registered. PR-URL: #4275 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Make it clear that error with throw if error listener is not registered. PR-URL: nodejs#4275 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor clarification on how errors surface on the HTTP module.
It's not clear that if a listener is not registered, the error will be thrown.
Bumped against it this weekend.