Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify core modules that can be loaded without a prefix #42753

Merged
merged 2 commits into from
Apr 19, 2022
Merged

doc: clarify core modules that can be loaded without a prefix #42753

merged 2 commits into from
Apr 19, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 15, 2022

Refs: #42325

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Apr 15, 2022
VoltrexKeyva
VoltrexKeyva reviewed Apr 16, 2022
View reviewed changes
doc/api/modules.md Outdated Show resolved Hide resolved
@aduh95 @VoltrexKeyva
Update doc/api/modules.md
79261a5 
Co-authored-by: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42753
✔  Done loading data for nodejs/node/pull/42753
----------------------------------- PR info ------------------------------------
Title      doc: clarify core modules that can be loaded without a prefix (#42753)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:update-docs-regarding-node-prefix -> nodejs:master
Labels     doc, module, author ready
Commits    2
 - doc: clarify core modules that can be loaded without a prefix
 - Update doc/api/modules.md
Committers 2
 - Antoine du Hamel 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/42753
Refs: https://github.com/nodejs/node/pull/42325
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mestery 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42753
Refs: https://github.com/nodejs/node/pull/42325
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mestery 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Apr 2022 23:32:28 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/42753#pullrequestreview-943891795
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/42753#pullrequestreview-943919035
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42753#pullrequestreview-943983208
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 42753
From https://github.com/nodejs/node
 * branch                  refs/pull/42753/merge -> FETCH_HEAD
✔  Fetched commits as 1e761654d3d9..79261a5ba49a
--------------------------------------------------------------------------------
[master ccf5bc3d7e] doc: clarify core modules that can be loaded without a prefix
 Author: Antoine du Hamel 
 Date: Sat Apr 16 01:30:35 2022 +0200
 1 file changed, 8 insertions(+), 5 deletions(-)
[master 8d50e21ad5] Update doc/api/modules.md
 Author: Antoine du Hamel 
 Date: Sat Apr 16 14:48:29 2022 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

⚠  Found Refs: #42325, skipping..

--------------------------------- New Message ----------------------------------

doc: clarify core modules that can be loaded without a prefix


Refs: #42325


PR-URL: #42753

Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com

Reviewed-By: Jacob Smith jacob@frende.me

Reviewed-By: Mestery mestery@protonmail.com


[detached HEAD 353677d959] doc: clarify core modules that can be loaded without a prefix

Author: Antoine du Hamel duhamelantoine1995@gmail.com

Date: Sat Apr 16 01:30:35 2022 +0200

1 file changed, 8 insertions(+), 5 deletions(-)

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update doc/api/modules.md


Co-authored-by: Mohammed Keyvanzadeh mohammadkeyvanzade94@gmail.com


PR-URL: #42753

Refs: #42325

Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com

Reviewed-By: Jacob Smith jacob@frende.me

Reviewed-By: Mestery mestery@protonmail.com


[detached HEAD 67e492cf01] Update doc/api/modules.md

Author: Antoine du Hamel duhamelantoine1995@gmail.com

Date: Sat Apr 16 14:48:29 2022 +0200

1 file changed, 1 insertion(+), 1 deletion(-)


Successfully rebased and updated refs/heads/master.


ℹ  Use --fixupAll option, squash the PR manually or land the PR from the command line.
https://github.com/nodejs/node/actions/runs/2192673947

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Apr 19, 2022
@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1fe5d56 into nodejs:master Apr 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1fe5d56

@aduh95 aduh95 deleted the update-docs-regarding-node-prefix branch April 19, 2022 23:36
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@aduh95 @xtx1130
doc: clarify core modules that can be loaded without a prefix
c69da56 
Refs: nodejs#42325

PR-URL: nodejs#42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2022
@aduh95 @targos
doc: clarify core modules that can be loaded without a prefix
46c880b 
Refs: #42325

PR-URL: #42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@aduh95 @juanarbol
doc: clarify core modules that can be loaded without a prefix
e638271 
Refs: #42325

PR-URL: #42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@aduh95 @danielleadams
doc: clarify core modules that can be loaded without a prefix
fb08ae7 
Refs: #42325

PR-URL: #42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@aduh95 @targos
doc: clarify core modules that can be loaded without a prefix
3d4f90f 
Refs: #42325

PR-URL: #42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
doc: clarify core modules that can be loaded without a prefix
b5a3c04 
Refs: #42325

PR-URL: #42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
doc: clarify core modules that can be loaded without a prefix
68e3229 
Refs: nodejs/node#42325

PR-URL: nodejs/node#42753
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Mestery <mestery@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva left review comments

@Mesteery Mesteery Mesteery approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @Mesteery @VoltrexKeyva