build: improve reliability of find_python.cmd script #42810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
install
Trott
approved these changes
Apr 21, 2022
Trott
added
author ready
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs#42801
jasnell
approved these changes
Apr 21, 2022
lpinca
force-pushed
the
handle/paths-with-spaces
branch
from
4e44222
to
2faf997
Compare
github-actions
bot
removed
the
request-ci
This was referenced Apr 22, 2022
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e2ff1c3 |
This was referenced Apr 24, 2022
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs#42801 PR-URL: nodejs#42810 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
14 tasks
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
The path of the Python executable might contain white spaces. Handle this when the `check-python` function is called. Fixes: nodejs/node#42801 PR-URL: nodejs/node#42810 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path of the Python executable might contain white spaces. Handle
this when the
check-pythonfunction is called.Fixes: #42801