test: skip test that cannot pass under --node-builtin-modules-path

[GeoffreyBooth]

Fixes #40879.

The test test-worker-init-failure.js cannot pass when Node is built using --node-builtin-modules-path, because the test intentionally lowers the limit of the number of files that can be concurrently opened and using builtin modules blows past this limit. See error in #40879 (comment).

The test is already skipped in Windows environments. This PR makes it also get skipped when Node is built using --node-builtin-modules-path. This makes development easier, as now I can develop using --node-builtin-modules-path and run the tests and expect all of them to pass (unless my new code broke something). cc @HarshithaKP @addaleax @Trott

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43648/

[Trott]

@nodejs/testing

[aduh95]

This test has also been failing for me locally, and I think skipping it make sense. Could it be a macOS specific limitation? I don't remember seeing this error when I was compiling on a Linux machine. If that's the case, we may want to add os.platform()==='darwin' in the condition.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/43657/

[GeoffreyBooth]

Could it be a macOS specific limitation? I don’t remember seeing this error when I was compiling on a Linux machine.

It fails in Linux too. I triggered a CI build for master with --node-builtin-modules-path: https://ci.nodejs.org/job/node-test-commit-linux/45540/nodes=alpine-last-latest-x64/consoleFull

19:00:12 python3 ./configure --verbose --node-builtin-modules-path /home/iojs/build/workspace/node-test-commit-linux/
19:00:13 Node.js configure: Found Python 3.8.2…
19:00:13 Detected C++ compiler (CXX=ccache g++) version: 9.3.0
19:00:13 Detected C compiler (CC=ccache gcc) version: 9.3.0
19:00:13 Warning! Loading builtin modules from disk is for development
…
19:09:31 not ok 2950 parallel/test-worker-init-failure
19:09:31   ---
19:09:31   duration_ms: 1.23
19:09:31   severity: fail
19:09:31   exitcode: 1
19:09:31   stack: |-
19:09:31     child stdout: 
19:09:31     
19:09:31     child stderr: /home/iojs/build/workspace/node-test-commit-linux/out/Release/node[4537]: ../src/node_worker.cc:332:void node::worker::Worker::Run(): Assertion `(env_) != nullptr' failed.
19:09:31     
19:09:31     
19:09:31     node:assert:123
19:09:31       throw new AssertionError(obj);
19:09:31       ^
19:09:31     
19:09:31     AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
19:09:31     
19:09:31     null !== 0
19:09:31     
19:09:31         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/parallel/test-worker-init-failure.js:65:12)
19:09:31         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux/test/common/index.js:438:15)
19:09:31         at ChildProcess.emit (node:events:527:28)
19:09:31         at ChildProcess._handle.onexit (node:internal/child_process:291:12) {
19:09:31       generatedMessage: true,
19:09:31       code: 'ERR_ASSERTION',
19:09:31       actual: null,
19:09:31       expected: 0,
19:09:31       operator: 'strictEqual'
19:09:31     }
19:09:31     
19:09:31     Node.js v19.0.0-pre

That’s the only failing test.

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/42834
✔  Done loading data for nodejs/node/pull/42834
----------------------------------- PR info ------------------------------------
Title      test: skip test that cannot pass under --node-builtin-modules-path (#42834)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     GeoffreyBooth:builtin-modules-path-test -> nodejs:master
Labels     test, flaky-test, author ready, worker
Commits    1
 - test: skip test that cannot pass under --node-builtin-modules-path
Committers 1
 - Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/42834
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42834
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 23 Apr 2022 04:42:56 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42834#pullrequestreview-950951284
   ✖  This PR needs to wait 107 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-04-24T00:45:56Z: https://ci.nodejs.org/job/node-test-pull-request/43657/
- Querying data for job/node-test-pull-request/43657/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2221820838

[GeoffreyBooth]

✖ This PR needs to wait 107 more hours to land (or 0 hours if there is one more approval)

The collaborator guide section “Waiting for approvals” says “Before landing pull requests, allow 48 hours for input from other collaborators.” Searching elsewhere in the document I see “At least two collaborators must approve a pull request before the pull request lands. One collaborator approval is enough if the pull request has been open for more than seven days.” So I guess that’s where the commit queue bot’s rules come from. I didn’t remember this second rule; it would make sense to mention it under “Waiting for approvals.” cc @Trott @aduh95 @targos

[nodejs-github-bot]

Landed in f54bf28