Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: use Response URL as WebAssembly location #42842

Merged
merged 1 commit into from
Apr 25, 2022
Merged

lib,src: use Response URL as WebAssembly location #42842

merged 1 commit into from
Apr 25, 2022

Conversation

tniessen
Copy link
Member

As per (non-normative) Section 3 of the WebAssembly Web API spec, if the Response has a url, pass it to V8 so that V8 can construct a conforming WebAssembly location.

Refs: #42701

@tniessen
lib,src: use Response URL as WebAssembly location
b136aea 
As per Section 3 of the WebAssembly Web API spec.
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 23, 2022
@tniessen tniessen requested a review from devsnek April 23, 2022 21:32
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 23, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43656/

This was referenced Apr 24, 2022
Open
Open
@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 4f9bc41 into nodejs:master Apr 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 4f9bc41

This was referenced Apr 26, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Apr 28, 2022
@tniessen @targos
lib,src: use Response URL as WebAssembly location
ad82694 
As per Section 3 of the WebAssembly Web API spec.

PR-URL: #42842
Refs: #42701
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
@juanarbol
Copy link
Member

#42701 is pending to backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @nodejs-github-bot @juanarbol @devsnek @aduh95 @targos