-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src,crypto: remove uses of AllocatedBuffer
from crypto_rsa.cc
#42852
Merged
nodejs-github-bot
merged 1 commit into
nodejs:master
from
RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc
May 4, 2022
Merged
src,crypto: remove uses of AllocatedBuffer
from crypto_rsa.cc
#42852
nodejs-github-bot
merged 1 commit into
nodejs:master
from
RaisinTen:src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc
May 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refs: nodejs#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com>
Review requested:
|
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
labels
Apr 24, 2022
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Apr 26, 2022
@addaleax PTAL. |
addaleax
approved these changes
May 4, 2022
RaisinTen
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
May 4, 2022
tniessen
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 4, 2022
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
May 4, 2022
Landed in 7ff2170 |
RaisinTen
deleted the
src,crypto/remove-uses-of-AllocatedBuffer-from-crypto_rsa.cc
branch
May 5, 2022 04:41
Merged
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Refs: nodejs/node#39941 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#42852 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #39941
Signed-off-by: Darshan Sen raisinten@gmail.com