Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: bump jsdoccomment from 0.22.1 to 0.29.0 #42857

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 25, 2022

A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 25, 2022
@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. tools Issues and PRs related to the tools directory. and removed tools Issues and PRs related to the tools directory. labels Apr 25, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 2691222 into nodejs:master Apr 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 2691222

@Trott Trott deleted the update-jsdoccomment branch April 25, 2022 16:03
targos pushed a commit that referenced this pull request Apr 28, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: #42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
A bug in jsdoccomment 0.28.0 forced us to pin to an earlier version. The
bug has been fixed now, so we can update.

Refs: es-joy/jsdoccomment#8

PR-URL: nodejs/node#42857
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants