Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors,console: refactor to use ES2020 & ES2021 syntax #42872

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

xtx1130
Copy link
Contributor

@xtx1130 xtx1130 commented Apr 26, 2022

errors,console: refactor to use ES2020 & ES2021 syntax
Just simplified some codes while I'm reading the newest codes for nodejs. PTAL

ref: #42088. ps: I have found this pr isn't merge yet, and I use rebase to this pr, this is long time ago and I must do something wrong :(…… So I open a new pr for this, sorry for wasting everyone's time

@nodejs-github-bot nodejs-github-bot added console Issues and PRs related to the console subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Apr 26, 2022
@aduh95
Copy link
Contributor

aduh95 commented Apr 26, 2022

nit: the logical nullish assignment operator is ES2021 syntax, as it was part of this proposal: https://github.com/tc39/proposal-logical-assignment. Not that it matters a lot, but we could correct the commit message.

@xtx1130 xtx1130 changed the title errors,console: refactor to use ES2020 syntax errors,console: refactor to use ES2020 & ES2021 syntax Apr 26, 2022
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 merged commit 13ae59d into nodejs:master Apr 28, 2022
@aduh95
Copy link
Contributor

aduh95 commented Apr 28, 2022

Landed in 13ae59d

targos pushed a commit that referenced this pull request May 2, 2022
PR-URL: #42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
@targos targos mentioned this pull request May 2, 2022
juanarbol pushed a commit that referenced this pull request May 31, 2022
PR-URL: #42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
PR-URL: #42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#42872
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Issues and PRs related to the console subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants