[v16.x backport] src,inspector: fix empty MaybeLocal crash #42967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
|
@danielleadams I see you're working on v16.15.1 -- this would be a good candidate to backport as well, as it fixes a breaking bug I've found in nightwatch 2.x |
aduh95
changed the title
|
Can you cherry-pick the original commit that landed on |
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: nodejs#42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42409 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Dossar
force-pushed
the
src,inspector/fix-empty-MaybeLocal-crash
branch
from
894897c to
730d294
Compare
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: nodejs#42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42720 Fixes: nodejs#42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Dossar
force-pushed
the
src,inspector/fix-empty-MaybeLocal-crash
branch
from
730d294 to
bbd5fe6
Compare
|
@richardlau @aduh95 apologies for the delay, I've cherrypicked the commits mentioned. Commit 97c442a: cherrypicked from be01185 |
github-actions
bot
removed
the
request-ci
BethGriggs
approved these changes
May 31, 2022
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport--PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
17 tasks
juanarbol
pushed a commit
that referenced
this pull request
Jun 1, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport-PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jun 1, 2022
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
This is amazing! Thanks for the help; your first PR goes to an LTS release Landed in 933d9ca...4fd90f1 🎉 💚 |
BethGriggs
pushed a commit
that referenced
this pull request
Jun 1, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport-PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jun 1, 2022
It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: #42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42720 Backport-PR-URL: #42967 Fixes: #42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #42409 to backport into node 16. Below credit of RaisinTen