Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: fix heap snapshot crash on exit #43123

Closed
wants to merge 1 commit into from
Closed

worker: fix heap snapshot crash on exit #43123

wants to merge 1 commit into from

Commits on May 17, 2022

  1. worker: fix heap snapshot crash on exit 

    Worker.parent_port_ can be released before the exit event of Worker. The
parent_port_ is not owned by `node::worker::Worker`, thus the reference
to it is not always valid, and accessing it at exit crashes the process.

As the Worker.parent_port_ is only used in the memory info tracking, it
can be safely removed.
    @legendecas
    legendecas committed May 17, 2022
    Configuration menu
    Copy the full SHA
    8560e8e View commit details
    Browse the repository at this point in the history