Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns: make promise API fully constructed from lib/internal/dns/promises #43227

Merged
merged 1 commit into from
Jun 20, 2022
Merged

dns: make promise API fully constructed from lib/internal/dns/promises #43227

merged 1 commit into from
Jun 20, 2022

Conversation

F3n67u
Copy link
Member

@F3n67u F3n67u commented May 28, 2022

This pr makes the whole promise API be fully constructed from lib/internal/dns/promises.js, it should not be split between lib/dns.js and lib/internal/dns/promises.js.

Refs: #43198

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels May 28, 2022
@F3n67u F3n67u marked this pull request as ready for review May 28, 2022 06:07
@F3n67u F3n67u changed the title dns: make the whole promise API be fully constructed from lib/internal/dns/promises.js dns: make promise API be fully constructed from lib/internal/dns/promises.js May 28, 2022
@F3n67u F3n67u changed the title dns: make promise API be fully constructed from lib/internal/dns/promises.js dns: make promise API fully constructed from lib/internal/dns/promises.js May 28, 2022
@F3n67u F3n67u force-pushed the fix/dns branch 2 times, most recently from bbb4612 to eea50fa Compare May 28, 2022 06:11
@F3n67u F3n67u changed the title dns: make promise API fully constructed from lib/internal/dns/promises.js dns: make promise API fully constructed from lib/internal/dns/promises May 28, 2022
mcollina
mcollina approved these changes May 28, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot mentioned this pull request May 29, 2022
Open
18 tasks
@F3n67u
Copy link
Member Author

F3n67u commented May 29, 2022 •
edited
Loading

Jenkins test is failed, please help to fire another Jenkins try.

There is two js test fail: parallel/test-worker-http2-stream-terminate and node-api/test_buffer/test_finalizer.

parallel/test-worker-http2-stream-terminate is a known flaky test, see #43084.

node-api/test_buffer/test_finalizer is failed 6 times today, perhaps not caused by this pr.

@github-actions github-actions bot mentioned this pull request May 30, 2022
Open
18 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44233/

This was referenced May 31, 2022
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jun 4, 2022
Open
21 tasks
@F3n67u F3n67u force-pushed the fix/dns branch 2 times, most recently from 280b9d5 to afa6194 Compare June 18, 2022 13:16
@F3n67u
Copy link
Member Author

F3n67u commented Jun 18, 2022

I rebased main branch to resolve a conflict.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44719/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44720/

@github-actions github-actions bot mentioned this pull request Jun 20, 2022
Open
36 tasks
@F3n67u F3n67u added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44740/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44761/

mcollina
mcollina approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Jun 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3847617 into nodejs:main Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3847617

@F3n67u F3n67u deleted the fix/dns branch June 21, 2022 00:09
@F3n67u
Copy link
Member Author

F3n67u commented Jun 21, 2022

lgtm

@mcollina thanks for landing this pr.

This was referenced Jun 21, 2022
Open
Open
Open
Open
F3n67u added a commit to F3n67u/node that referenced this pull request Jun 24, 2022
@F3n67u
dns: make promise API fully constructed from lib/internal/dns/promises
2dae13f 
PR-URL: nodejs#43227
Refs: nodejs#43198
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
@F3n67u @targos
dns: make promise API fully constructed from lib/internal/dns/promises
2149acd 
PR-URL: #43227
Refs: #43198
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos targos mentioned this pull request Jul 12, 2022
Merged
targos pushed a commit that referenced this pull request Jul 20, 2022
@F3n67u @targos
dns: make promise API fully constructed from lib/internal/dns/promises
a8f7d0d 
PR-URL: #43227
Refs: #43198
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@F3n67u @targos
dns: make promise API fully constructed from lib/internal/dns/promises
8d2a256 
PR-URL: #43227
Refs: #43198
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@F3n67u @guangwong
dns: make promise API fully constructed from lib/internal/dns/promises
22f4881 
PR-URL: nodejs/node#43227
Refs: nodejs/node#43198
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dns Issues and PRs related to the dns subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@F3n67u @nodejs-github-bot @mcollina @lpinca @targos @JungMinu