doc: fix Visual Studio 2019 download link #43236
Conversation
nodejs-github-bot
added
build
| the "C++ build tools" workload from the | ||
| [Build Tools](https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019), | ||
| [Build Tools](https://aka.ms/vs/16/release/vs_buildtools.exe), |
There was a problem hiding this comment.
https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 link is also broken, I cannot find a visual studio 2019 c++ build tools link from https://visualstudio.microsoft.com/downloads.
Using https://aka.ms/vs/16/release/vs_buildtools.exe link to download visual studio 2019 build tools is documented at
https://docs.microsoft.com/en-us/visualstudio/install/build-tools-container?view=vs-2019#create-and-build-the-dockerfile.
I have verified this link does works on my windows server: uninstall already installed visual studio 2019, install build tool via the build tools link, and verify .\vcbuild does compile.
|
@targos could you please take a look at this pr? |
|
Hi @targo, could you help to land this pr? Thanks. |
targos
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 08d6a82 |
PR-URL: nodejs#43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: #43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs/node#43236 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Background: Building Node.js with Visual Studio 2022 is broken from Visual Studio 17.2, see #43092.
The https://visualstudio.microsoft.com/downloads/ now link to the latest Visual Studio 2022 version instead of 2019 is incorrect. If our windows new contributor follows the link and downloads the Visual Studio 2022, build will fail. I follow this link and download the 2022 version yesterday😂 and experience build failure.
https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 link is also broken, I cannot find a link to build-tools-for-visual-studio-2019 to replace it, so I delete the[Build Tools]link. If #43092 is resolved, we could add it again. or If anyone could find the link to build-tools-for-visual-studio-2019, please comment and I will add it.