Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: fix question stack overflow #43320

Merged
merged 2 commits into from
Jun 12, 2022
Merged

readline: fix question stack overflow #43320

merged 2 commits into from
Jun 12, 2022

Commits on Jun 5, 2022

  1. readline: fix question stack overflow 

    This commit fixes readline interface's question callback wrapping when
it is being called with `signal` option. Previous version completely
overwrites passed callback and throws "Maximum call stack size exceeded"
error.
    @chapko
    chapko committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    35fda91 View commit details
    Browse the repository at this point in the history

  2. readline: add test for promisified question

    @chapko
    chapko committed Jun 5, 2022
    Configuration menu
    Copy the full SHA
    473f03c View commit details
    Browse the repository at this point in the history