doc: fix typo in util.parseArgs usage example #43332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
michaelficarra
changed the title
lpinca
approved these changes
Jun 6, 2022
VoltrexKeyva
approved these changes
Jun 6, 2022
tniessen
approved these changes
Jun 6, 2022
RaisinTen
approved these changes
Jun 7, 2022
|
Fast-track has been requested by @lpinca. Please 👍 to approve. |
LiviaMedeiros
approved these changes
Jun 7, 2022
LiviaMedeiros
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/43332 ✔ Done loading data for nodejs/node/pull/43332 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in util.parseArgs usage example (#43332) Author Michael Ficarra (@michaelficarra, first-time contributor) Branch michaelficarra:patch-1 -> nodejs:master Labels util, doc, fast-track Commits 1 - doc: fix typo in util.parseArgs usage example Committers 1 - Michael Ficarra PR-URL: https://github.com/nodejs/node/pull/43332 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: LiviaMedeiros ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/43332 Reviewed-By: Luigi Pinca Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Tobias Nießen Reviewed-By: Darshan Sen Reviewed-By: LiviaMedeiros -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 06 Jun 2022 18:52:39 GMT ✔ Approvals: 5 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43332#pullrequestreview-997067301 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/43332#pullrequestreview-997296632 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43332#pullrequestreview-997301771 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/43332#pullrequestreview-997490584 ✔ - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/43332#pullrequestreview-998362312 ℹ This PR is being fast-tracked ✖ Last GitHub CI failed ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2455649235 |
LiviaMedeiros
removed
the
commit-queue-failed
|
Landed in aba2cd7 Thanks for the contribution! |
LiviaMedeiros
pushed a commit
that referenced
this pull request
Jun 7, 2022
PR-URL: #43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
PR-URL: #43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
PR-URL: #43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
|
Backport blocked on #42675 |
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.