Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix specifier example #43351

Merged
merged 2 commits into from
Jun 9, 2022
Merged

doc: fix specifier example #43351

merged 2 commits into from
Jun 9, 2022

Conversation

privatenumber
Copy link
Contributor

In the example, the specifier should include the node: prefix.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Jun 8, 2022
@privatenumber privatenumber changed the title docs: fix specifier example doc: fix specifier example Jun 8, 2022
GeoffreyBooth
GeoffreyBooth approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast track?

@GeoffreyBooth GeoffreyBooth added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2022

Fast-track has been requested by @GeoffreyBooth. Please 👍 to approve.

tniessen
tniessen approved these changes Jun 8, 2022
View reviewed changes
doc/api/esm.md Outdated Show resolved Hide resolved
@tniessen
Copy link
Member

tniessen commented Jun 8, 2022

Thank you for the contribution @privatenumber! The linter is failing because your first commit message begins with docs:, not doc:. I can fix that for you if you'd like, or you can force-push with an amended commit message.

privatenumber and others added 2 commits June 8, 2022 18:08
@privatenumber
doc: fix specifier example
5ebf440
@privatenumber @tniessen
Update doc/api/esm.md
8ecbcfc 
Co-authored-by: Tobias Nießen <tniessen@tnie.de>
@nodejs-github-bot

This comment was marked as off-topic.

Sign in to view
@aduh95 aduh95 merged commit 923f355 into nodejs:master Jun 9, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jun 9, 2022

Landed in 923f355

danielleadams pushed a commit that referenced this pull request Jun 11, 2022
@privatenumber @danielleadams
doc: fix specifier example in esm.md
03fc991 
PR-URL: #43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Jun 11, 2022
Merged
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@privatenumber @danielleadams
doc: fix specifier example in esm.md
119746a 
PR-URL: #43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 13, 2022
Open
15 tasks
danielleadams pushed a commit that referenced this pull request Jun 13, 2022
@privatenumber @danielleadams
doc: fix specifier example in esm.md
b824a0b 
PR-URL: #43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 14, 2022
Open
16 tasks
targos pushed a commit that referenced this pull request Jul 12, 2022
@privatenumber @targos
doc: fix specifier example in esm.md
d8a17b4 
PR-URL: #43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@privatenumber @targos
doc: fix specifier example in esm.md
82dc48d 
PR-URL: #43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@privatenumber @guangwong
doc: fix specifier example in esm.md
44d222b 
PR-URL: nodejs/node#43351
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@aduh95 aduh95 aduh95 approved these changes

@tniessen tniessen tniessen approved these changes

@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@privatenumber @nodejs-github-bot @tniessen @aduh95 @GeoffreyBooth @JakobJingleheimer @RaisinTen @VoltrexKeyva