Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: update Wrapping and unwrapping keys webcrypto doc example #43452

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

panva
Copy link
Member

@panva panva commented Jun 16, 2022

Updates the Wrapping and unwrapping keys webcrypto example so that wrappingKey is returned for use in unwrapHmacKey().

@panva panva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. webcrypto labels Jun 16, 2022
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 16, 2022
@lpinca
Copy link
Member

lpinca commented Jun 17, 2022

Nit: I would use doc: or doc,crypto: as subsystem in commit title.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit f9db884 into nodejs:main Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f9db884

F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
PR-URL: nodejs#43452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43452
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@panva panva deleted the webcrypto-wrap-example branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants