Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: handle webcrypto generateKey() usages edge case #43454

Merged
merged 1 commit into from
Jun 25, 2022

Conversation

panva
Copy link
Member

@panva panva commented Jun 16, 2022

As per spec:
Screenshot 2022-06-16 at 22 18 24

chrome:
image

The current check has an edge case with signing algorithms where only public key usages could be provided.

@panva panva added crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. webcrypto labels Jun 16, 2022
@panva panva requested review from jasnell and tniessen June 16, 2022 20:24
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 16, 2022
@panva panva force-pushed the webcrypto-empty-usage-check branch from fe50533 to d066a1c Compare June 17, 2022 12:46
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 17, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 17, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44714/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 25, 2022
@nodejs-github-bot nodejs-github-bot merged commit 84db3e7 into nodejs:main Jun 25, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 84db3e7

targos pushed a commit that referenced this pull request Jul 12, 2022
PR-URL: #43454
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 20, 2022
PR-URL: #43454
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Jul 31, 2022
PR-URL: #43454
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
PR-URL: nodejs/node#43454
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva panva deleted the webcrypto-empty-usage-check branch October 13, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants