src: change FormatSize to actually accept a size_t #43464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is only called with size_t values and it does not deal with unsigned values nicely, so its argument type should be size_t.
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
cjihrig
approved these changes
Jun 18, 2022
tniessen
added
the
author ready
lpinca
approved these changes
Jun 18, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Jun 19, 2022
tniessen
added
the
commit-queue
RaisinTen
approved these changes
Jun 20, 2022
nodejs-github-bot
removed
the
commit-queue
|
Landed in b574532 |
This was referenced Jun 21, 2022
F3n67u
pushed a commit
to F3n67u/node
that referenced
this pull request
Jun 24, 2022
This function is only called with size_t values and it does not deal with unsigned values nicely, so its argument type should be size_t. PR-URL: nodejs#43464 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This function is only called with size_t values and it does not deal with unsigned values nicely, so its argument type should be size_t. PR-URL: #43464 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is only called with
size_tvalues and it does not deal with unsigned values nicely, so its argument type should besize_t.