doc: fix website wg mislink #4357
Conversation
|
LGTM |
|
Is it possible to change the |
|
@mscdex i believe that's a github thing. the |
|
@sup Yeah, if they are willing to change it again I think that would be ideal. |
|
@mscdex contacted them, will update on further discussion |
|
i need confirmation from someone in the TSC, @mscdex, can you give me your email so i can cc you in the discussion? (or someone else from @nodejs/tsc) |
|
bump, i need an email address from someone on the tsc/ctc to confirm the redirect change |
|
The change LGTM. If others are on board with changing the |
|
FYI - @sup put me in contact with GitHub support, and I approved the redirect update. |
|
oh yeah, forgot to report about that - sorry! |
|
update, redirect is changed! nodejs/website now redirects to this repo, i'll close this PR as well. |
ghost
closed this
|
Yay! |
PR-URL: #4357 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
|
Even with the redirect we should probably update the doc to point to the correct repo. I've landed this commit @ 7c8efeb with 3 LGTMs, I don't read @mscdex' comments as a -1 for this particular change, I hope that's right (sorry if I've read wrong @mscdex). I believe this is your first commit to core @sup, thanks for the fix, welcome on board! |
PR-URL: nodejs#4357 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
PR-URL: nodejs#4357 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
nodejs/website->nodejs/nodejs.org