v8: serialize BigInt64Array and BigUint64Array

[bnoordhuis]

Teach the serializer about BigInt64Array and BigUint64Array.

I open-coded the type-to-index mapper to stay compatible with the
current wire format without undue code gymnastics.

[bnoordhuis]

This line made it kind of ugly and complex to simply extend the array literal on line 259.

[BridgeAR]

The following would work and be simpler (even though a bit hacky):

// Add "Array" as entry to arrayBufferViewTypes[10] above. Other constructors also work.
arrayBufferViewTypeToIndex.delete('[object Array]');
arrayBufferViewTypes[10] = FastBuffer;
const bufferConstructorIndex = 10;

[bnoordhuis]

I initially did something like that to keep the diff small but I made the judgment call the open-coded approach is going to be easier to understand and update.

[BridgeAR]

There is actually a even simpler solution:

--- a/lib/v8.js
+++ b/lib/v8.js
@@ -256,20 +256,23 @@ Deserializer.prototype.readRawBytes = function readRawBytes(length) {
  * itself, custom serialization is applied. */
 const arrayBufferViewTypes = [Int8Array, Uint8Array, Uint8ClampedArray,
                               Int16Array, Uint16Array, Int32Array, Uint32Array,
-                              Float32Array, Float64Array, DataView];
+                              Float32Array, Float64Array, DataView,
+                              FastBuffer, BigInt64Array, BigUint64Array];
 
 const arrayBufferViewTypeToIndex = new SafeMap();
 
 {
   const dummy = new ArrayBuffer();
   ArrayPrototypeForEach(arrayBufferViewTypes, (ctor, i) => {
+    if (ctor === FastBuffer) {
+      return;
+    }
     const tag = ObjectPrototypeToString(new ctor(dummy));
     arrayBufferViewTypeToIndex.set(tag, i);
   });
 }
 
-const bufferConstructorIndex =
-  ArrayPrototypePush(arrayBufferViewTypes, FastBuffer) - 1;
+const bufferConstructorIndex = 10;

[bnoordhuis]

Sorry, I never replied. That would work but... I don't get warm fuzzies from do-this-except-when-it's-that logic. It's shorter but IMO the virtue of the open-coded approach is it's glaringly obvious what it does because it's so stupidly simple.

[BridgeAR]

The following would work and be simpler (even though a bit hacky):

// Add "Array" as entry to arrayBufferViewTypes[10] above. Other constructors also work.
arrayBufferViewTypeToIndex.delete('[object Array]');
arrayBufferViewTypes[10] = FastBuffer;
const bufferConstructorIndex = 10;

[BridgeAR]

I would prefer the simpler approach that I suggested while this also works.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45318/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45421/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/45428/

[nodejs-github-bot]

Landed in 1643b9e