-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove windows xperf from tierlist #43607
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
mcollina
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
RafaelGSS
approved these changes
Jun 29, 2022
Flarna
approved these changes
Jun 29, 2022
tony-go
force-pushed
the
remove-win-xperf-tierlist
branch
from
July 2, 2022 18:33
608e9e2
to
e92c7b7
Compare
Rebased ↪️ |
lpinca
pushed a commit
that referenced
this pull request
Jul 3, 2022
PR-URL: #43607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Landed in dca76e7. |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #43607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2022
PR-URL: #43607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #43607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#43607 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey 👋
Context
The diagnostic working group currently works on an initiative to re-evaluate the diagnostic tooling list and its maturity.
Updated
In the previous instance, we examined the case of the
Windows xperf
module: issue link.As anyone in the instance has an idea about a potential usage in the field, we decided to remove it. As said in the previous PRs, we prefer to have a list that contains fewer items but is trustable.
But in case you have a different opinion, please share your thoughts in this PR 🙏.
Discuss
As usual, feel free to share your thoughts on that and your experience with this tool.
With love ❤️
cc @nodejs/diagnostics