build,test: increase stack size limit on Windows #43632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tniessen
added
windows
|
Review requested:
|
tniessen
force-pushed
the
build-increase-thread-stack-size-limit-windows
branch
from
598a8eb
to
88fc47b
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bnoordhuis
approved these changes
Jun 30, 2022
tniessen
added
the
author ready
This comment was marked as outdated.
This comment was marked as outdated.
gengjiawen
approved these changes
Jul 1, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 71691e5 |
23 tasks
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
Fixes: nodejs/node#43630 PR-URL: nodejs/node#43632 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 2, 2023
On windows the default stack size is still limited to 1MB in older versions of node. See nodejs/node#43632 which made it into v19.0.0. Fixes: emscripten-core#17897
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Dec 4, 2023
On windows the default stack size is still limited to 1MB in older versions of node. See nodejs/node#43632 which made it into v19.0.0. Fixes: #17897
tniessen
added a commit
to tniessen/node-pqclean
that referenced
this pull request
Mar 7, 2024
All supported Node.js release lines have increased the stack size on Windows, so it is no longer necessary to use WebAssembly to access certain algorithms on Windows. Refs: nodejs/node#43632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the virtual stack space available to each thread from 1 MiB to 8 MiB.
Fixes: #43630