Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: remove rpm build scripts #43647

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Conversation

bnoordhuis
Copy link
Member

I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.

I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 1, 2022
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I would like to consider that this may explode NodeSource's rpm distributions; would you mind if I reach NodeSource distributions first (before landing this)? AFAIK, lots of people use it to install Node.js; this could potentially affect lots of people

@bnoordhuis
Copy link
Member Author

@juanarbol Sure, go ahead. I believe @rvagg once mentioned you don't but that was years ago.

@JesusPaz
Copy link

JesusPaz commented Jul 5, 2022

Thank you @juanarbol for asking us. @bnoordhuis is right, we don't use these files anymore. They can be removed without affecting us.

@juanarbol
Copy link
Member

:shipit:

@juanarbol
Copy link
Member

Do this needs CI?

@bnoordhuis
Copy link
Member Author

Nope, nothing tests it.

@bnoordhuis bnoordhuis added request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 11, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 11, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7a0164a into nodejs:main Jul 11, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7a0164a

@bnoordhuis bnoordhuis deleted the rm-rpm branch July 11, 2022 18:33
targos pushed a commit that referenced this pull request Jul 12, 2022
I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.

PR-URL: #43647
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 20, 2022
I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.

PR-URL: #43647
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.

PR-URL: #43647
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
I added these in 2013 but I don't think anyone uses them and I'm not
even sure they still produce a working package.

I move to remove them because that makes subsequent cleanup a little
easier.

PR-URL: nodejs/node#43647
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.