test: remove unnecessary .toString() calls in HTTP tests #43731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let’s not have bad examples in our test suite and instead use the
proper way of converting stream data to UTF-8
(i.e. `stream.setEncoding('utf8')`) in all places.
nodejs-github-bot
added
needs-ci
addaleax
added
http
targos
approved these changes
Jul 8, 2022
github-actions
bot
removed
the
request-ci
richardlau
approved these changes
Jul 8, 2022
F3n67u
reviewed
Jul 8, 2022
| @@ -26,7 +26,7 @@ server.listen(0, common.mustSucceed(() => { | |||
| let response = ''; | |||
|
|
|||
| client.on('data', common.mustCall((chunk) => { | |||
| response += chunk.toString('utf-8'); | |||
| response += chunk; | |||
| })); | |||
|
|
|||
| client.setEncoding('utf8'); | |||
There was a problem hiding this comment.
Nit(feel free to ignore): would be better to move client.setEncoding('utf8'); before client.on('data'?
Reason:
- keep consistent with other use cases
- don't make us guess if
client.setEncoding('utf8')after attachdatalistener would cause problem.
There was a problem hiding this comment.
Fwiw, my preferred way is client.setEncoding('utf8').on('data', ...') 😄
Ultimately, it doesn't matter. If we do clean this up, it might also be a good idea to do so across all tests for consistency.
|
Maybe it is time to doc-deprecate buffer.toString() params at all? |
I don't think that that's practical or meaningful. We should just push really hard to avoid examples like these so that people know not to do it this way 🙂 Also, this is something that TypeScript would have caught at least in the cases where |
lpinca
approved these changes
Jul 8, 2022
RaisinTen
approved these changes
Jul 8, 2022
aduh95
approved these changes
Jul 8, 2022
aduh95
added
author ready
21 tasks
F3n67u
approved these changes
Jul 9, 2022
20 tasks
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in febb539 |
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
Let’s not have bad examples in our test suite and instead use the
proper way of converting stream data to UTF-8
(i.e. `stream.setEncoding('utf8')`) in all places.
PR-URL: #43731
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let’s not have bad examples in our test suite and instead use the
proper way of converting stream data to UTF-8
(i.e.
stream.setEncoding('utf8')) in all places.