Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] src: fix IS_LTS and IS_RELEASE flags #43761

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Jul 10, 2022

Clear the NODE_VERSION_IS_RELEASE flag and restore the
NODE_VERSION_IS_LTS flag.

Refs: https://github.com/nodejs/node/runs/7271286633?check_suite_focus=true


cc @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 10, 2022
Clear the `NODE_VERSION_IS_RELEASE` flag and restore the
`NODE_VERSION_IS_LTS` flag.
@richardlau richardlau force-pushed the v14.x-staging-flags branch from aa688b9 to 14297d9 Compare July 12, 2022 14:51
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

richardlau added a commit that referenced this pull request Jul 12, 2022
Clear the `NODE_VERSION_IS_RELEASE` flag and restore the
`NODE_VERSION_IS_LTS` flag.

PR-URL: #43761
Refs: https://github.com/nodejs/node/runs/7271286633?check_suite_focus=true
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
@richardlau
Copy link
Member Author

Landed in de80707.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants