Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x backport] lib: use null-prototype objects for property descriptors #43804

Closed
wants to merge 1 commit into from
Closed

[v16.x backport] lib: use null-prototype objects for property descriptors #43804

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 12, 2022

Refs: #42921

PR-URL: #43270
Reviewed-By: Paolo Insogna paolo@cowtech.it
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Chengzhong Wu legendecas@gmail.com
Reviewed-By: Minwoo Jung nodecorelab@gmail.com

@aduh95
lib: use null-prototype objects for property descriptors
449105b 
Refs: nodejs#42921

PR-URL: nodejs#43270
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/modules
  • @nodejs/net
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Jul 12, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/45382/

This was referenced Jul 14, 2022
Open
Open
targos pushed a commit that referenced this pull request Jul 18, 2022
@aduh95 @targos
lib: use null-prototype objects for property descriptors
4dc6fea 
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos
Copy link
Member

targos commented Jul 18, 2022

Thanks. Landed in 4dc6fea

@targos targos closed this Jul 18, 2022
targos pushed a commit that referenced this pull request Jul 31, 2022
@aduh95 @targos
lib: use null-prototype objects for property descriptors
cd55e22 
Refs: #42921
PR-URL: #43270
Backport-PR-URL: #43804
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@aduh95 @guangwong
lib: use null-prototype objects for property descriptors
7a32176 
Refs: nodejs/node#42921
PR-URL: nodejs/node#43270
Backport-PR-URL: nodejs/node#43804
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas legendecas approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @targos @ShogunPanda @legendecas