Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #44110

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fix typos #44110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fdb5e1
src: fix typo in src/node_messaging.h
sadikkuzu Aug 2, 2022
59d8a1b
test/es-module: fix typo in test-cjs-exports.js
sadikkuzu Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_messaging.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ class MessagePort : public HandleWrap {
};

// Provide a base class from which JS classes that should be transferable or
// cloneable by postMesssage() can inherit.
// cloneable by postMessage() can inherit.
// See e.g. FileHandle in internal/fs/promises.js for an example.
class JSTransferable : public BaseObject {
public:
Expand Down
2 changes: 1 addition & 1 deletion test/es-module/test-esm-cjs-exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('ESM: importing CJS', { concurrency: true }, () => {
assert.strictEqual(stdout, 'ok\n');
});

it('should eror on invalid CJS exports', async () => {
it('should error on invalid CJS exports', async () => {
const invalidEntry = fixtures.path('/es-modules/cjs-exports-invalid.mjs');
const { code, signal, stderr } = await spawnPromisified(execPath, [invalidEntry]);

Expand Down