Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix isDetachedBuffer validations in ReadableStream #44114

Merged
merged 9 commits into from
Aug 18, 2022
Merged

stream: fix isDetachedBuffer validations in ReadableStream #44114

merged 9 commits into from
Aug 18, 2022

Commits on Aug 3, 2022

  1. stream: fix isDetachedBuffer validations 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 3, 2022
    Configuration menu
    Copy the full SHA
    e5e32c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. fixup: check zero and add asserts 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    50c7728 View commit details
    Browse the repository at this point in the history

  2. fixup: use isDetachedBuffer only 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    6f6ba3e View commit details
    Browse the repository at this point in the history

  3. revert "fixup: use isDetachedBuffer only" 

    This reverts commit 6f6ba3e.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    782c71a View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2022

  1. fixup: remove redundant isDetachedBuffer 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    e44effa View commit details
    Browse the repository at this point in the history

  2. fixup: improve the checker 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 6, 2022
    Configuration menu
    Copy the full SHA
    6fd3ea1 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2022

  1. fixup: change error message properly 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    0cc34f4 View commit details
    Browse the repository at this point in the history

  2. fixup: use assert for isDetachedBuffer 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 7, 2022
    Configuration menu
    Copy the full SHA
    fe816cd View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2022

  1. fixup: apply suggestions 

    Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
    @daeyeon
    daeyeon committed Aug 18, 2022
    Configuration menu
    Copy the full SHA
    58da0d8 View commit details
    Browse the repository at this point in the history