Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove unused variables from net tests #4430

Closed
wants to merge 1 commit into from
Closed

test: remove unused variables from net tests #4430

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 26, 2015

No description provided.

@Trott Trott added net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. labels Dec 26, 2015
@Trott
Copy link
Member Author

Trott commented Dec 26, 2015

CI: https://ci.nodejs.org/job/node-test-commit/1538/

@targos
Copy link
Member

targos commented Dec 27, 2015

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Dec 29, 2015

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Dec 29, 2015
@Trott
test: remove unused variables from net tests
1762db0 
Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 29, 2015

Landed in 1762db0

@Trott Trott closed this Dec 29, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
@Trott @Fishrock123
test: remove unused variables from net tests
c6a99dd 
Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 14, 2016
Merged
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Jan 14, 2016
@Trott
test: remove unused variables from net tests
8c094be 
Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
@Trott
test: remove unused variables from net tests
da9e5c1 
Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: #4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Merged
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
@Trott
test: remove unused variables from net tests
1068404 
Remove a handful of variables that are declared but never used in the
tests for the net module.

PR-URL: nodejs#4430
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the rm-unused-net branch January 13, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @targos @cjihrig @MylesBorins