src: simplify SFINAE of ToStringHelper::BaseConvert
#44306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
F3n67u
changed the title
ToStringHelper::BaseConvertToStringHelper::BaseConvert
github-actions
bot
removed
the
request-ci
This was referenced Aug 21, 2022
jasnell
approved these changes
Aug 28, 2022
RaisinTen
added
the
author ready
F3n67u
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f36813c |
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 5, 2022
PR-URL: #44306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 6, 2022
PR-URL: #44306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Sep 7, 2022
PR-URL: #44306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Fyko
pushed a commit
to Fyko/node
that referenced
this pull request
Sep 15, 2022
PR-URL: nodejs#44306 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
For some reason, this is not compiling in the v16.x branch. It may be related to a cpp version or something. esult -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++14 -MMD -MF /home/juanarbol/GitHub/node/out/Release/.deps//home/juanarbol/GitHub/node/out/Release/obj.target/libnode/src/module_wrap.o.d.raw -c
In file included from ../src/js_stream.cc:5:
In file included from ../src/node_errors.h:6:
../src/debug_utils-inl.h:32:46: error: no template named 'is_integral_v' in namespace 'std'; did you mean 'is_integral'?
typename = std::enable_if_t<std::is_integral_v<T>>>
~~~~~^~~~~~~~~~~~~
is_integral
/usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/type_traits:392:12: note: 'is_integral' declared here
struct is_integral
^
In file included from ../src/js_stream.cc:5:
In file included from ../src/node_errors.h:6:
../src/debug_utils-inl.h:32:41: error: template argument for non-type template parameter must be an expression
typename = std::enable_if_t<std::is_integral_v<T>>>And the complaints grow and grow. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify SFINAE of
ToStringHelper::BaseConvertusing technique from https://www.fluentcpp.com/2018/05/18/make-sfinae-pretty-2-hidden-beauty-sfinae/