http: throw error on content-length mismatch

[sidwebworks]

Resolves #39041

• Update documentation
• Add tests
• Fix any older broken tests due to this breaking change

Tests cases
there are 3 test cases defined in the test-http-content-length-mismatch.js file.

• shouldThrowOnMoreBytes: if the content-length header exists and we write more than the length it should throw.

• shouldNotThrow: if the content-length header exists and the number of bytes written match it should not throw.

• shouldThrowOnFewerBytes: if the content-length is header exists and fewer bytes are written it should throw on calling .end() without the remaining bytes.

[nodejs-github-bot]

Review requested:

• @nodejs/http
• @nodejs/net

[sidwebworks]

Hi @ronag, what do you suggest for this

shouldNotThrow: if the content-length matches or is less than the header value, it should not throw

Should I add a check if the user calls res.end() and the content-length is has fewer bytes than the given header value?

[sidwebworks]

Ah looks like my commit message didn't adhere to the convention, Sorry I will fix these CI errors and will clean up the commit tree with rebase (I am still a bit new to rebase).

[theanarkh]

You can run make lint on your PC to see what the error is and fix it.

[sidwebworks]

I have fixed all the existing broken tests however sometimes the test-v8-serialize-leak.js seems to fail.

=== release test-v8-serialize-leak ===
Path: parallel/test-v8-serialize-leak
node:assert:400
    throw err;
    ^

AssertionError [ERR_ASSERTION]: before=38879232 after=83558400
    at Object.<anonymous> (/Users/sww/Desktop/opensource/node/test/parallel/test-v8-serialize-leak.js:26:3)
    at Module._compile (node:internal/modules/cjs/loader:1119:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1173:10)
    at Module.load (node:internal/modules/cjs/loader:997:32)
    at Module._load (node:internal/modules/cjs/loader:838:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
    at node:internal/main/run_main_module:23:47 {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: false,
  expected: true,
  operator: '=='
}

Node.js v19.0.0-pre
Command: out/Release/node --expose-gc /Users/sww/Desktop/opensource/node/test/parallel/test-v8-serialize-leak.js

That's the only thing stopping me from updating my branch with the latest local changes, can someone help?

#42695

CC// @addaleax

[sidwebworks]

@mcollina can you please review my changes?

[mcollina]

Can you add an option to turn on and off the check? Marking it false by default will make this change non-breakin. Then you can open a separate PR to flip the default.

[sidwebworks]

Can you add an option to turn on and off the check? Marking it false by default will make this change non-breakin. Then you can open a separate PR to flip the default.

Sure I will add this now

[sidwebworks]

@mcollina Done, OutgoingMessage.strictContentLength can now be used to toggle this behaviour

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/46491/