Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky cluster-net-send #4444

Closed

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Dec 28, 2015

Before this commit, it was possible on Windows for the server's 'connection' handler to be called after the client socket's 'connect' handler. This caused the 'message' event to be missed and the test would never end (timing out in CI). This problem was more easily reproducible on a low resource (slow CPU) Windows (2012r2) installation.

This commit waits until both handlers have been called before sending the handle to the master process.

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Dec 28, 2015
@mscdex mscdex force-pushed the fix-win-flaky-test-cluster-net-send branch from 7625a84 to 7e47b40 Compare December 28, 2015 06:20
@mscdex
Copy link
Contributor Author

mscdex commented Dec 28, 2015

@mscdex
Copy link
Contributor Author

mscdex commented Dec 29, 2015

Stress test is green \o/

@mscdex
Copy link
Contributor Author

mscdex commented Dec 29, 2015

@mscdex mscdex force-pushed the fix-win-flaky-test-cluster-net-send branch from 7e47b40 to c3ea849 Compare December 29, 2015 04:38
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: nodejs#3957
PR-URL: nodejs#4444
@mscdex mscdex force-pushed the fix-win-flaky-test-cluster-net-send branch from c3ea849 to 0fb7ef2 Compare December 29, 2015 04:41
@Trott
Copy link
Member

Trott commented Dec 29, 2015

Failures on CI seem unrelated. LGTM.

mscdex added a commit that referenced this pull request Dec 29, 2015
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: #3957
PR-URL: #4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Dec 29, 2015

Landed in 3809126.

@mscdex mscdex closed this Dec 29, 2015
@mscdex mscdex deleted the fix-win-flaky-test-cluster-net-send branch December 29, 2015 05:16
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Jan 6, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: nodejs#3957
PR-URL: nodejs#4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 28, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: #3957
PR-URL: #4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 11, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: #3957
PR-URL: #4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 11, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: nodejs#3957
PR-URL: nodejs#4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 11, 2016
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Feb 15, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: nodejs#3957
PR-URL: nodejs#4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
scovetta pushed a commit to scovetta/node that referenced this pull request Apr 2, 2016
Before this commit, it was possible on Windows for the server's
'connection' handler to be called *after* the client socket's
'connect' handler. This caused the 'message' event to be missed
and the test would never end (timing out in CI). This problem
was more easily reproducible on a low resource (slow CPU)
Windows (2012r2) installation.

This commit waits until both handlers have been called before
sending the handle to the master process.

Fixes: nodejs#3957
PR-URL: nodejs#4444
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants