2022-10-18, Version 19.0.0 (Current) #44626

RafaelGSS · 2022-09-13T16:08:03Z

_{*This is just an early draft proposal to enable test builds and will be updated weekly.}

Release date: 2022-10-18
Release content freeze: 2022-10-11
- _{We no longer have a strict semver-major cut-off. The proposal content will be in sync with master until 2022-10-11.}

2022-10-18, Version 19.0.0 (Current), @RafaelGSS and @ruyadorno

Node.js 19 is here! Highlights include the update of the V8 JavaScript engine to 10.7, HTTP(s)/1.1 KeepAlive enabled by default, and ESM Resolution adjusts.

Node.js 19 will replace Node.js 18 as our ‘Current’ release line when Node.js 18 enters long-term support (LTS) later this month.
As per the release schedule, Node.js 19 will be ‘Current' release for the next 6 months, until April 2023.

Notable Changes

Deprecations and Removals

[7dd2f41c73] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495
[ada2d053ae] - (SEMVER-MAJOR) process: runtime deprecate coercion to integer in process.exit() (Daeyeon Jeong) #44711

HTTP(S)/1.1 KeepAlive by default

Starting with this release, Node.js sets keepAlive to true by default. This means that any outgoing HTTP(s) connection will automatically use HTTP 1.1 Keep-Alive. The default waiting window is 5 seconds.
Enable keep-alive will deliver better throughput as connections are reused by default.

Additionally the agent is now able to parse the response Keep-Alive which the servers might send. This header instructs the client on how much to stay connected.
On the other side, the Node.js HTTP server will now automatically disconnect idle clients (which are using HTTP Keep-Alive to reuse the connection) when close() is invoked).

Node.js HTTP(S)/1.1 requests may experience a better throughput/performance by default.

Contributed by Paolo Insogna in #43522

DTrace/SystemTap/ETW Support were removed

The main reason is the lack of resources from Node.js team. The complexity to keep the support up-to-date has been proved not worth it without a clear plan to support those tools. Hence, an issue was raised in the Node.js repository to assess a better support, for DTrace in specific.

Contributed by Ben Noordhuis in #43651 and #43652

V8 10.7

The V8 engine is updated to version 10.7, which is part of Chromium 107.
This version include a new feature to the JavaScript API: Intl.NumberFormat.

Intl.NumberFormat v3 API is a new TC39 ECMA402 stage 3 proposal
extend the pre-existing Intl.NumberFormat.

The V8 update was a contribution by Michaël Zasso in #44741.

llhttp 8.1.0

llhttp has been updated to version 8.1.0.Collectively, this version brings many update to the llhttp API, introducing new callbacks and allow all callback to be pausable.

Contributed by Paolo Insogna in #44967

Other Notable Changes

[46a3afb579] - doc: graduate webcrypto to stable (Filip Skokan) #44897
[f594cc85b7] - esm: remove specifier resolution flag (Geoffrey Booth) #44859

Semver-Major Commits

[53f73d1cfe] - (SEMVER-MAJOR) build: enable V8's trap handler on Windows (Michaël Zasso) #44741
[06aaf8a1c4] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #44741
[aa3a572e6b] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652
[38f1e2793c] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651
[2849283c4c] - (SEMVER-MAJOR) crypto: remove non-standard webcrypto.Crypto.prototype.CryptoKey (Antoine du Hamel) #42083
[a1653ac715] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624
[fd36a8dadb] - (SEMVER-MAJOR) deps: update llhttp to 8.1.0 (Paolo Insogna) #44967
[89ecdddaab] - (SEMVER-MAJOR) deps: bump minimum ICU version to 71 (Michaël Zasso) #44741
[66fe446efd] - (SEMVER-MAJOR) deps: V8: cherry-pick 0cccb6f27d78 (Michaël Zasso) #44741
[88ed027d57] - (SEMVER-MAJOR) deps: V8: cherry-pick 7ddb8399f9f1 (Michaël Zasso) #44741
[26c651c34e] - (SEMVER-MAJOR) deps: V8: cherry-pick 1b3a4f0c34a1 (Michaël Zasso) #44741
[c8ff2dfd11] - (SEMVER-MAJOR) deps: V8: cherry-pick b161a0823165 (Michaël Zasso) #44741
[7a8fa2d517] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #44741
[83b0aaa800] - (SEMVER-MAJOR) deps: fix V8 build on SmartOS (Michaël Zasso) #44741
[7a952e8ea5] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #44741
[6bd756d7c6] - (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741
[03fb789fb9] - (SEMVER-MAJOR) events: add null check for the signal of EventTarget (Masashi Hirano) #43153
[a4fa526ddc] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894
[bb4891d8d4] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769
[950a4411fa] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796
[41a6d82968] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772
[2275faac2b] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772
[29953a0b88] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772
[4267b92604] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522
[0324529e0f] - (SEMVER-MAJOR) inspector: introduce inspector/promises API (Erick Wendel) #44250
[80270994d6] - (SEMVER-MAJOR) lib: enable global CustomEvent by default (Daeyeon Jeong) #44860
[f529f73bd7] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483
[6de2673a9f] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083
[73ba8830d5] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820
[7dd2f41c73] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495
[22c39b1ddd] - (SEMVER-MAJOR) path: the dot will be added(path.format) if it is not specified in ext (theanarkh) #44349
[587367d107] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483
[364c0e196c] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483
[ada2d053ae] - (SEMVER-MAJOR) process: runtime deprecate coercion to integer in process.exit() (Daeyeon Jeong) #44711
[e0ab8dd637] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627
[481a959adb] - (SEMVER-MAJOR) readline: remove question method from InterfaceConstructor (Antoine du Hamel) #44606
[c9602ce212] - (SEMVER-MAJOR) src: use new v8::OOMErrorCallback API (Michaël Zasso) #44741
[19a70c11e4] - (SEMVER-MAJOR) src: override CreateJob instead of PostJob (Clemens Backes) #44741
[fd52c62bee] - (SEMVER-MAJOR) src: use V8_ENABLE_SANDBOX macro (Michaël Zasso) #44741
[c10988db44] - (SEMVER-MAJOR) src: use non-deprecated V8 inspector API (Michaël Zasso) #44741
[3efe901dd6] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 111 (Michaël Zasso) #44741
[77e585657f] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629
[dabda03ea9] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781
[2e49b99cc2] - (SEMVER-MAJOR) src,test: disable freezing V8 flags on initialization (Clemens Backes) #44741
[2b32985c62] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312
[36805e8524] - (SEMVER-MAJOR) test: adapt test-repl for V8 update (Michaël Zasso) #44741
[96ef25793d] - (SEMVER-MAJOR) test: adapt test-repl-pretty-*stack to V8 changes (Michaël Zasso) #44741
[71c193e581] - (SEMVER-MAJOR) test: adapt to new JSON SyntaxError messages (Michaël Zasso) #44741
[b5f1564880] - (SEMVER-MAJOR) test: rename always-opt flag to always-turbofan (Michaël Zasso) #44741
[1acf0339dd] - (SEMVER-MAJOR) test: fix test-hash-seed for new V8 versions (Michaël Zasso) #44741
[57ff476c33] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051
[77def91bf9] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031
[4860ad99b9] - (SEMVER-MAJOR) tools: update V8 gypfiles for 10.7 (Michaël Zasso) #44741

Semver-Minor Commits

[af0921d877] - (SEMVER-MINOR) esm: add --import flag (Moshe Atlow) #43942
[0633e9a0b5] - (SEMVER-MINOR) lib: add diagnostics channel for process and worker (theanarkh) #44045
[ca5be26b31] - (SEMVER-MINOR) src: add support for externally shared js builtins (Michael Dawson) #44376
[e86a638305] - (SEMVER-MINOR) src: add initial shadow realm support (Chengzhong Wu) #42869
[71ca6d7d6a] - (SEMVER-MINOR) util: add maxArrayLength option to Set and Map (Kohei Ueno) #43576

Semver-Patch Commits

[78508028e3] - bootstrap: generate bootstrapper arguments in BuiltinLoader (Joyee Cheung) #44488
[5291096ca2] - bootstrap: check more metadata when loading the snapshot (Joyee Cheung) #44132
[d0f73d383d] - build: go faster, drop -fno-omit-frame-pointer (Ben Noordhuis) #44452
[214354fc9f] - crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey (Filip Skokan) #44917
[40a0757b21] - crypto: remove webcrypto HKDF and PBKDF2 default-applied lengths (Filip Skokan) #44945
[eeec3eb16a] - crypto: simplify webcrypto ECDH deriveBits (Filip Skokan) #44946
[0be1c57281] - deps: V8: cherry-pick c2792e58035f (Jiawen Geng) #44961
[488474618c] - deps: V8: cherry-pick c3dffe6e2bda (Michaël Zasso) #44958
[34ba631a0b] - deps: V8: cherry-pick e7f0f26f5ef3 (Michaël Zasso) #44958
[690a837f4f] - deps: V8: cherry-pick 3d59a3c2c164 (Michaël Zasso) #44958
[bab8b3aad6] - deps: V8: cherry-pick 8b8703953616 (Michaël Zasso) #44958
[37e5152245] - doc: add notable changes to latest v18.x release changelog (Danielle Adams) #44996
[19a909902a] - doc: deprecate url.parse() (Rich Trott) #44919
[6686d9000b] - doc: fix backticks in fs API docs (Livia Medeiros) #44962
[46a3afb579] - doc: graduate webcrypto to stable (Filip Skokan) #44897
[6e3c55cc35] - doc: fix v16.17.1 security release changelog (Ruy Adorno) #44759
[77cb88b91c] - doc: mark --import as experimental (Moshe Atlow) #44067
[46dcfb3c7b] - doc,crypto: update webcrypto docs for global access (Filip Skokan) #44723
[f594cc85b7] - esm: remove specifier resolution flag (Geoffrey Booth) #44859
[3c040348fe] - Revert "esm: convert resolve hook to synchronous" (Jacob Smith) #43526
[90b634a5a5] - esm: convert resolve hook to synchronous (Jacob Smith) #43363
[7c06eab1dc] - Revert "http: do not leak error listeners" (Luigi Pinca) #44921
[464d1c1558] - lib: reset RegExp statics before running user code (Antoine du Hamel) #43741
[15f10515e3] - module: fix segment deprecation for imports field (Guy Bedford) #44883
[7cdf745fdd] - perf_hooks: convert maxSize to IDL value in setResourceTimingBufferSize (Chengzhong Wu) #44902
[be525d7d04] - src: consolidate exit codes in the code base (Joyee Cheung) #44746
[d5ce285c8b] - src: refactor BaseObject methods (Joyee Cheung) #44796
[717465433c] - src: create BaseObject with node::Realm (Chengzhong Wu) #44348
[45f2258f74] - src: restore IS_RELEASE to 0 (Bryan English) #44758
[1f54fc25cb] - src: use automatic memory mgmt in SecretKeyGen (Tobias Nießen) #44479
[7371d335ac] - src: use V8 entropy source if RAND_bytes() != 1 (Tobias Nießen) #44493
[81d9cdb8cd] - src: introduce node::Realm (Chengzhong Wu) #44179
[ad41c919df] - src: remove v8abbr.h (Tobias Nießen) #44402
[fddc701d3c] - src: support diagnostics channel in the snapshot (Joyee Cheung) #44193
[d70aab663c] - src: support WeakReference in snapshot (Joyee Cheung) #44193
[4ca398a617] - src: iterate over base objects to prepare for snapshot (Joyee Cheung) #44192
[8b0e5b19bd] - src: fix cppgc incompatibility in v8 (Shelley Vohr) #43521
[3fdf6cfad9] - stream: fix size function returned from QueuingStrategies (Daeyeon Jeong) #44867
[331088f4a4] - Revert "tools: refactor tools/license2rtf to ESM" (Richard Lau) #43214
[30cb1bf8b8] - tools: refactor tools/license2rtf to ESM (Feng Yu) #43101
[a3ff4bfc66] - url: revert "validate ipv4 part length" (Antoine du Hamel) #42940
[87d0d7a069] - url: validate ipv4 part length (Yagiz Nizipli) #42915
[5b1bcf82f1] - vm: make ContextifyContext a BaseObject (Joyee Cheung) #44796

nodejs-github-bot · 2022-09-13T16:08:08Z

Review requested:

@nodejs/http
@nodejs/http2
@nodejs/net

CHANGELOG.md

targos · 2022-09-15T09:40:09Z

I'm marking this blocked on #44650 just to ensure some visibility on that issue. The label can be removed a few days before the release if we end up not being able to update V8 (which would be very unfortunate).

srl295 · 2022-09-15T15:55:37Z

FYI to @nodejs/i18n-api or whom it may concern Unicode 15 was just released, and ICU 72 is final in October with an RC coming soon.

Notable Changes: Deprecation and Removals: * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 Other Notable Changes: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 Semver-Major Commits: * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

Notable Changes: cli: * (SEMVER-MINOR) add `--watch` (Moshe Atlow) #44366 esm: * remove specifier resolution flag (Geoffrey Booth) #44859 * convert `resolve` hook to synchronous (Jacob Smith) #43363 http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 build: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 Deprecation and Removals: * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 Semver-Major Commits: * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [a4fa526] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894 * [bb4891d] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [f529f73] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [587367d] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483 * [364c0e1] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

GeoffreyBooth · 2022-10-04T14:09:51Z

[90b634a] - esm: convert resolve hook to synchronous (Jacob Smith) #43363 was reverted.

targos · 2022-10-08T09:44:43Z

For the V8 update, as far as I understand from https://chromestatus.com/roadmap, the only new JS feature is https://github.com/tc39/proposal-intl-numberformat-v3

RafaelGSS · 2022-10-08T22:39:44Z

For the V8 update, as far as I understand from https://chromestatus.com/roadmap, the only new JS feature is https://github.com/tc39/proposal-intl-numberformat-v3

Thank you!

We're currently evaluating the changelog. 2022-10-11 is the final update and we'll be able to write the final content.

Notable Changes: cli: * (SEMVER-MINOR) add `--watch` (Moshe Atlow) #44366 esm: * remove specifier resolution flag (Geoffrey Booth) #44859 * convert `resolve` hook to synchronous (Jacob Smith) #43363 http: * (SEMVER-MINOR) add writeEarlyHints function to ServerResponse (Wing) #44180 * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 build: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 Deprecation and Removals: * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 Semver-Major Commits: * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [a4fa526] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894 * [bb4891d] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [f529f73] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [587367d] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483 * [364c0e1] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

RafaelGSS · 2022-10-11T19:08:38Z

FYI I'm waiting for the v18.11.0 release before updating the changelog and the commits.

Technically, today is the code freeze:

Release date: 2022-10-18

Release content freeze: 2022-10-11

Are there any PRs that must land in v19.0.0 that cannot wait for v19.1.0? (Please update the below list)

deps: cherry-pick commits to be forward-compatible with V8 10.8 #44958
events: add null check for the signal of EventTarget #43153
deps: update llhttp to 8.1.0 #44967
crypto: simplify webcrypto ECDH deriveBits #44946 (because we marked webcrypto stable from 19.x onward)
crypto: remove webcrypto HKDF and PBKDF2 default-applied lengths #44945 (because we marked webcrypto stable from 19.x onward)
crypto: fix webcrypto HMAC "get key length" in deriveKey and generateKey #44917 (because we marked webcrypto stable from 19.x onward)

cc: @nodejs/releasers @nodejs/tsc

RafaelGSS · 2022-10-12T11:36:58Z

@panva FYI the crypto PRs aren't semver-major which means they could land in the next v19 release (v19.1.0). By policy we cannot move the release date at this point. Hence, the major release will proceed regardless semver-minor/patch in the above list

panva · 2022-10-12T11:41:02Z

@panva FYI the crypto PRs aren't semver-major which means they could land in the next v19 release (v19.1.0). By policy we cannot move the release date at this point. Hence, the major release will proceed regardless semver-minor/patch in the above list

@RafaelGSS I'm not asking to move the release date, these PRs will land today/tomorrow after a round of reviews from @tniessen.

They are not semver-major because on the 18.x release they're still part of an experimental module and I was assuming we'll get them in the 19.0.0 release next week which will include a PR that marks the webcrypto module stable (that PR is already landed in master but will not be part of a 18.x release).

panva · 2022-10-12T11:46:30Z

Alternatively, if there's no will to include these in 19.0.0, I would ask that we postpone #44897 to 19.1.0 which would then include these 3 as well. Whichever is easier for you.

ShogunPanda · 2022-10-12T13:33:20Z

Can we please also have #44731 in this?

BethGriggs

Release commit LGTM. (I haven't had chance to review CITGMs)

targos · 2022-10-18T10:46:52Z

Quick citgm analysis (based on the results of fedora runs):

https://ci.nodejs.org/job/citgm-smoker/3023/nodes=fedora-latest-x64/#showFailuresLink

Many fastify errors (@mcollina)
bodyparser and express tests error because of change in V8's error message format
bufferutil errors because of the frozen process.config. I think it will be fixed if a release is published with websockets/bufferutil@134c979 (@lpinca)
https-proxy-agent should be investigated. There's an OpenSSL error.
is-core-module and resolve fail because of inspector/promises (@ljharb)
jest fails because performance is read-only (@SimenB)
uuid tests fail because crypto is now global (@ctavan)
undici fails (@nodejs/undici)

SimenB · 2022-10-18T11:24:34Z

Oh, it's today! 😃

I'll get a jest patch out today or tomorrow 👍

mcollina · 2022-10-18T11:26:52Z

I'm sorry I got notified of the Fastify & undici breakages only at the very last minute :/. I should have looked.

Fastify uses undici internally, so undici is the starting point.
I will know more once I look into the errors, but they seem legit and the result of a breaking change. I do not exclude there is some lurking bug in Node too.

ctavan · 2022-10-18T11:31:03Z

What’s the easiest way to reproduce the test failure?

SimenB · 2022-10-18T11:32:43Z

What’s the easiest way to reproduce the test failure?

I was gonna download latest nightly (https://nodejs.org/download/nightly/). If there are better ways I'd love to hear 🙂

targos · 2022-10-18T11:34:56Z

Yes, you can download the latest nightly or release candidate: https://nodejs.org/download/rc/v19.0.0-rc.2/

RafaelGSS · 2022-10-18T11:54:12Z

For the fastify errors, I've opened a Draft PR fastify/fastify#4350

lpinca · 2022-10-18T13:39:32Z

bufferutil errors because of the frozen process.config. I think it will be fixed if a release is published with websockets/bufferutil@134c979 (@lpinca)

Done.

PR-URL: #44626

Notable Changes: doc: * graduate webcrypto to stable (Filip Skokan) #44897 esm: * remove specifier resolution flag (Geoffrey Booth) #44859 http: * (SEMVER-MAJOR) use Keep-Alive by default in global agents (Paolo Insogna) #43522 build: * (SEMVER-MAJOR) remove dtrace & etw support (Ben Noordhuis) #43652 * (SEMVER-MAJOR) remove systemtap support (Ben Noordhuis) #43651 deps: * (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741 Deprecation and Removals: * deprecate url.parse() (Rich Trott) #44919 * (SEMVER-MAJOR) runtime deprecate exports double slash maps (Guy Bedford) #44495 * (SEMVER-MAJOR) runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 Semver-Major Commits: * [53f73d1] - (SEMVER-MAJOR) build: enable V8's trap handler on Windows (Michaël Zasso) #44741 * [06aaf8a] - (SEMVER-MAJOR) build: reset embedder string to "-node.0" (Michaël Zasso) #44741 * [aa3a572] - (SEMVER-MAJOR) build: remove dtrace & etw support (Ben Noordhuis) #43652 * [38f1e27] - (SEMVER-MAJOR) build: remove systemtap support (Ben Noordhuis) #43651 * [2849283] - (SEMVER-MAJOR) crypto: remove non-standard `webcrypto.Crypto.prototype.CryptoKey` (Antoine du Hamel) #42083 * [a1653ac] - (SEMVER-MAJOR) crypto: do not allow to call setFips from the worker thread (Sergey Petushkov) #43624 * [fd36a8d] - (SEMVER-MAJOR) deps: update llhttp to 8.1.0 (Paolo Insogna) #44967 * [89ecddd] - (SEMVER-MAJOR) deps: bump minimum ICU version to 71 (Michaël Zasso) #44741 * [66fe446] - (SEMVER-MAJOR) deps: V8: cherry-pick 0cccb6f27d78 (Michaël Zasso) #44741 * [88ed027] - (SEMVER-MAJOR) deps: V8: cherry-pick 7ddb8399f9f1 (Michaël Zasso) #44741 * [26c651c] - (SEMVER-MAJOR) deps: V8: cherry-pick 1b3a4f0c34a1 (Michaël Zasso) #44741 * [c8ff2df] - (SEMVER-MAJOR) deps: V8: cherry-pick b161a0823165 (Michaël Zasso) #44741 * [7a8fa2d] - (SEMVER-MAJOR) deps: fix V8 build on Windows with MSVC (Michaël Zasso) #44741 * [83b0aaa] - (SEMVER-MAJOR) deps: fix V8 build on SmartOS (Michaël Zasso) #44741 * [7a952e8] - (SEMVER-MAJOR) deps: silence irrelevant V8 warning (Michaël Zasso) #44741 * [6bd756d] - (SEMVER-MAJOR) deps: update V8 to 10.7.193.13 (Michaël Zasso) #44741 * [03fb789] - (SEMVER-MAJOR) events: add null check for the signal of EventTarget (Masashi Hirano) #43153 * [a4fa526] - (SEMVER-MAJOR) fs: add directory autodetection to fsPromises.symlink() (Livia Medeiros) #42894 * [bb4891d] - (SEMVER-MAJOR) fs: add validateBuffer to improve error (Hirotaka Tagawa / wafuwafu13) #44769 * [950a441] - (SEMVER-MAJOR) fs: remove coercion to string in writing methods (Livia Medeiros) #42796 * [41a6d82] - (SEMVER-MAJOR) fs: harden fs.readSync(buffer, options) typecheck (LiviaMedeiros) #42772 * [2275faa] - (SEMVER-MAJOR) fs: harden fs.read(params, callback) typecheck (LiviaMedeiros) #42772 * [29953a0] - (SEMVER-MAJOR) fs: harden filehandle.read(params) typecheck (LiviaMedeiros) #42772 * [4267b92] - (SEMVER-MAJOR) http: use Keep-Alive by default in global agents (Paolo Insogna) #43522 * [0324529] - (SEMVER-MAJOR) inspector: introduce inspector/promises API (Erick Wendel) #44250 * [8027099] - (SEMVER-MAJOR) lib: enable global CustomEvent by default (Daeyeon Jeong) #44860 * [f529f73] - (SEMVER-MAJOR) lib: brand check event handler property receivers (Chengzhong Wu) #44483 * [6de2673] - (SEMVER-MAJOR) lib: enable global WebCrypto by default (Antoine du Hamel) #42083 * [73ba883] - (SEMVER-MAJOR) lib: use private field in AbortController (Joyee Cheung) #43820 * [7dd2f41] - (SEMVER-MAJOR) module: runtime deprecate exports double slash maps (Guy Bedford) #44495 * [22c39b1] - (SEMVER-MAJOR) path: the dot will be added(path.format) if it is not specified in `ext` (theanarkh) #44349 * [587367d] - (SEMVER-MAJOR) perf_hooks: expose webperf global scope interfaces (Chengzhong Wu) #44483 * [364c0e1] - (SEMVER-MAJOR) perf_hooks: fix webperf idlharness (Chengzhong Wu) #44483 * [ada2d05] - (SEMVER-MAJOR) process: runtime deprecate coercion to integer in `process.exit()` (Daeyeon Jeong) #44711 * [e0ab8dd] - (SEMVER-MAJOR) process: make process.config read only (Sergey Petushkov) #43627 * [481a959] - (SEMVER-MAJOR) readline: remove `question` method from `InterfaceConstructor` (Antoine du Hamel) #44606 * [c9602ce] - (SEMVER-MAJOR) src: use new v8::OOMErrorCallback API (Michaël Zasso) #44741 * [19a70c1] - (SEMVER-MAJOR) src: override CreateJob instead of PostJob (Clemens Backes) #44741 * [fd52c62] - (SEMVER-MAJOR) src: use V8_ENABLE_SANDBOX macro (Michaël Zasso) #44741 * [c10988d] - (SEMVER-MAJOR) src: use non-deprecated V8 inspector API (Michaël Zasso) #44741 * [3efe901] - (SEMVER-MAJOR) src: update NODE_MODULE_VERSION to 111 (Michaël Zasso) #44741 * [77e5856] - (SEMVER-MAJOR) src: turn embedder api overload into default argument (Alena Khineika) #43629 * [dabda03] - (SEMVER-MAJOR) src: per-environment time origin value (Chengzhong Wu) #43781 * [2e49b99] - (SEMVER-MAJOR) src,test: disable freezing V8 flags on initialization (Clemens Backes) #44741 * [2b32985] - (SEMVER-MAJOR) stream: use null for the error argument (Luigi Pinca) #44312 * [36805e8] - (SEMVER-MAJOR) test: adapt test-repl for V8 update (Michaël Zasso) #44741 * [96ef257] - (SEMVER-MAJOR) test: adapt test-repl-pretty-*stack to V8 changes (Michaël Zasso) #44741 * [71c193e] - (SEMVER-MAJOR) test: adapt to new JSON SyntaxError messages (Michaël Zasso) #44741 * [b5f1564] - (SEMVER-MAJOR) test: rename always-opt flag to always-turbofan (Michaël Zasso) #44741 * [1acf033] - (SEMVER-MAJOR) test: fix test-hash-seed for new V8 versions (Michaël Zasso) #44741 * [57ff476] - (SEMVER-MAJOR) test: remove duplicate test (Luigi Pinca) #44051 * [77def91] - (SEMVER-MAJOR) tls,http2: send fatal alert on ALPN mismatch (Tobias Nießen) #44031 * [4860ad9] - (SEMVER-MAJOR) tools: update V8 gypfiles for 10.7 (Michaël Zasso) #44741 PR-URL: #44626 Co-authored-by: Ruy Adorno <ruyadorno@google.com>

ljharb · 2022-10-18T14:26:51Z

Only 4 hours between a ping and this landing :-/ i can have an is-core-module update out today but I’d have preferred to have it out before the release.

Refs: nodejs/node#44626

* Blog: Node.js 19 release announcement Refs: nodejs/node#44626 * Blog: v19.0.0 release post Refs: nodejs/node#44626

ljharb · 2022-10-18T17:09:25Z

is-core-module v2.11.0` has been published.

nodejs-github-bot added meta Issues and PRs related to the general management of the project. v19.x labels Sep 13, 2022

RafaelGSS added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels Sep 13, 2022

richardlau reviewed Sep 13, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

RafaelGSS force-pushed the v19.0.0-proposal branch from dd8b55e to 0567e77 Compare September 13, 2022 16:18

targos added the blocked PRs that are blocked by other issues or PRs. label Sep 15, 2022

RafaelGSS force-pushed the v19.0.0-proposal branch from 0567e77 to 96923d1 Compare September 21, 2022 15:15

ruyadorno force-pushed the v19.0.0-proposal branch from 96923d1 to 48e148b Compare September 27, 2022 16:01

This comment was marked as outdated.

Sign in to view

RafaelGSS force-pushed the v19.0.0-proposal branch from 48e148b to d23aefb Compare October 4, 2022 10:38

RafaelGSS force-pushed the v19.0.0-proposal branch from d23aefb to ab691a5 Compare October 4, 2022 10:45

This comment was marked as outdated.

Sign in to view

RafaelGSS force-pushed the v19.0.0-proposal branch from ab691a5 to f85f907 Compare October 11, 2022 19:00

BethGriggs approved these changes Oct 17, 2022

View reviewed changes

github-actions bot mentioned this pull request Oct 18, 2022

CI Reliability 2022-10-18 nodejs/reliability#403

Open

13 tasks

ruyadorno approved these changes Oct 18, 2022

View reviewed changes

danielleadams approved these changes Oct 18, 2022

View reviewed changes

tniessen approved these changes Oct 18, 2022

View reviewed changes

This was referenced Oct 18, 2022

fix(jest-environment-node): make performance writable jestjs/jest#13467

Merged

Feature: Add support for a different distribution URI actions/setup-node#360

Closed

RafaelGSS added a commit that referenced this pull request Oct 18, 2022

Working on v19.0.1

6546435

PR-URL: #44626

RafaelGSS merged commit cc993fb into v19.x Oct 18, 2022

RafaelGSS deleted the v19.0.0-proposal branch October 18, 2022 14:12

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Oct 18, 2022

Blog: Node.js 19 release announcement

02e16da

Refs: nodejs/node#44626

RafaelGSS added a commit to RafaelGSS/nodejs.org that referenced this pull request Oct 18, 2022

Blog: v19.0.0 release post

dad489a

Refs: nodejs/node#44626

RafaelGSS added a commit to nodejs/nodejs.org that referenced this pull request Oct 18, 2022

Blog: Node.js 19 release announcement and post (#4890)

5f0e19b

* Blog: Node.js 19 release announcement Refs: nodejs/node#44626 * Blog: v19.0.0 release post Refs: nodejs/node#44626

This was referenced Oct 19, 2022

CI Reliability 2022-10-19 nodejs/reliability#404

Open

CI Reliability 2022-10-20 nodejs/reliability#405

Open

CI Reliability 2022-10-21 nodejs/reliability#406

Open

CI Reliability 2022-10-22 nodejs/reliability#407

Open

RafaelGSS mentioned this pull request Apr 13, 2023

2023-04-18, Version 20.0.0 (Current) #47381

Merged

SimenB mentioned this pull request Sep 6, 2023

[v20.6] CJS runs repeatedly when there are circular dependencies when loaded by ESM #49497

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2022-10-18, Version 19.0.0 (Current) #44626

2022-10-18, Version 19.0.0 (Current) #44626

RafaelGSS commented Sep 13, 2022 •

edited

Loading

nodejs-github-bot commented Sep 13, 2022

targos commented Sep 15, 2022

srl295 commented Sep 15, 2022

This comment was marked as outdated.

This comment was marked as outdated.

GeoffreyBooth commented Oct 4, 2022

targos commented Oct 8, 2022

RafaelGSS commented Oct 8, 2022

RafaelGSS commented Oct 11, 2022 •

edited by panva

Loading

RafaelGSS commented Oct 12, 2022

panva commented Oct 12, 2022 •

edited

Loading

panva commented Oct 12, 2022 •

edited

Loading

ShogunPanda commented Oct 12, 2022

BethGriggs left a comment

targos commented Oct 18, 2022 •

edited

Loading

SimenB commented Oct 18, 2022

mcollina commented Oct 18, 2022 •

edited

Loading

ctavan commented Oct 18, 2022

SimenB commented Oct 18, 2022

targos commented Oct 18, 2022

RafaelGSS commented Oct 18, 2022

lpinca commented Oct 18, 2022

ljharb commented Oct 18, 2022

ljharb commented Oct 18, 2022

2022-10-18, Version 19.0.0 (Current) #44626

2022-10-18, Version 19.0.0 (Current) #44626

Conversation

RafaelGSS commented Sep 13, 2022 • edited Loading

2022-10-18, Version 19.0.0 (Current), @RafaelGSS and @ruyadorno

Notable Changes

Deprecations and Removals

HTTP(S)/1.1 KeepAlive by default

DTrace/SystemTap/ETW Support were removed

V8 10.7

llhttp 8.1.0

Other Notable Changes

Semver-Major Commits

Semver-Minor Commits

Semver-Patch Commits

nodejs-github-bot commented Sep 13, 2022

targos commented Sep 15, 2022

srl295 commented Sep 15, 2022

This comment was marked as outdated.

This comment was marked as outdated.

GeoffreyBooth commented Oct 4, 2022

targos commented Oct 8, 2022

RafaelGSS commented Oct 8, 2022

RafaelGSS commented Oct 11, 2022 • edited by panva Loading

RafaelGSS commented Oct 12, 2022

panva commented Oct 12, 2022 • edited Loading

panva commented Oct 12, 2022 • edited Loading

ShogunPanda commented Oct 12, 2022

BethGriggs left a comment

Choose a reason for hiding this comment

targos commented Oct 18, 2022 • edited Loading

SimenB commented Oct 18, 2022

mcollina commented Oct 18, 2022 • edited Loading

ctavan commented Oct 18, 2022

SimenB commented Oct 18, 2022

targos commented Oct 18, 2022

RafaelGSS commented Oct 18, 2022

lpinca commented Oct 18, 2022

ljharb commented Oct 18, 2022

ljharb commented Oct 18, 2022

RafaelGSS commented Sep 13, 2022 •

edited

Loading

RafaelGSS commented Oct 11, 2022 •

edited by panva

Loading

panva commented Oct 12, 2022 •

edited

Loading

panva commented Oct 12, 2022 •

edited

Loading

targos commented Oct 18, 2022 •

edited

Loading

mcollina commented Oct 18, 2022 •

edited

Loading