Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change promises to async/await #44697

Merged
merged 1 commit into from
Sep 29, 2022
+21 −32
Merged

test: change promises to async/await #44697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 21 additions & 32 deletions test/sequential/test-debugger-sb-before-load.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,24 @@ const assert = require('assert');
const path = require('path');

// Using sb before loading file.
{
const scriptFullPath = fixtures.path('debugger', 'cjs', 'index.js');
const script = path.relative(process.cwd(), scriptFullPath);

const otherScriptFullPath = fixtures.path('debugger', 'cjs', 'other.js');
const otherScript = path.relative(process.cwd(), otherScriptFullPath);

const cli = startCLI([script]);

function onFatal(error) {
cli.quit();
throw error;
}

cli.waitForInitialBreak()
.then(() => cli.waitForPrompt())
.then(() => cli.command('sb("other.js", 2)'))
.then(() => {
assert.match(
cli.output,
/not loaded yet/,
'warns that the script was not loaded yet');
})
.then(() => cli.stepCommand('cont'))
.then(() => {
assert.ok(
cli.output.includes(`break in ${otherScript}:2`),
'found breakpoint in file that was not loaded yet');
})
.then(() => cli.quit())
.then(null, onFatal);
}

const scriptFullPath = fixtures.path('debugger', 'cjs', 'index.js');
const script = path.relative(process.cwd(), scriptFullPath);

const otherScriptFullPath = fixtures.path('debugger', 'cjs', 'other.js');
const otherScript = path.relative(process.cwd(), otherScriptFullPath);

const cli = startCLI([script]);

(async () => {
await cli.waitForInitialBreak();
await cli.waitForPrompt();
await cli.command('sb("other.js", 2)');
assert.match(cli.output, /not loaded yet/,
'warns that the script was not loaded yet');
await cli.stepCommand('cont');
assert.ok(cli.output.includes(`break in ${otherScript}:2`),
'found breakpoint in file that was not loaded yet');
})()
.then(common.mustCall())
.finally(() => cli.quit());