Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] crypto: fix webcrypto operation errors to be OperationError #44836

Closed
wants to merge 1 commit into from

Conversation

panva
Copy link
Member

@panva panva commented Sep 30, 2022

Refs: #44171

This backports the runtime functionality without the portion that updated the wpt status file which in turn depended on the WPT Runner update (#43455).

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Sep 30, 2022
PR-URL: nodejs#44171
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Backport-PR-URL: nodejs#44836
@panva panva force-pushed the backport-44171-to-v16.x branch from 69aefb1 to 45839e7 Compare September 30, 2022 12:03
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the crypto Issues and PRs related to the crypto subsystem. label Sep 30, 2022
@panva
Copy link
Member Author

panva commented Sep 30, 2022

cc @juanarbol this is the best I can do without having to backport the WPT runner update

@panva panva added webcrypto request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2022
@nodejs-github-bot

This comment was marked as outdated.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2022
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants