V16.18.0 proposal

.github/CODEOWNERS

@@ -109,6 +109,7 @@
 /src/node.cc @nodejs/startup
 /src/node_code_cache_stub.cc @nodejs/startup
 /src/node_native_module* @nodejs/startup
+/src/node_snapshot* @nodejs/startup
 /lib/internal/bootstrap/* @nodejs/startup
 /tools/code_cache/* @nodejs/startup
 /tools/snapshot/* @nodejs/startup

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -19,7 +19,7 @@ body:
       label: Platform
       description: |
         UNIX: output of `uname -a`
-        Windows: output of `"$([Environment]::OSVersion | ForEach-Object VersionString) $(if ([Environment]::Is64BitOperatingSystem) { "x64" } else { "x86" })"` in PowerShell console
+        Windows: output of `"$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"` in PowerShell console
   - type: input
     attributes:
       label: Subsystem

.github/label-pr-config.yml

@@ -101,6 +101,8 @@ subSystemLabels:
   /^lib\/worker_threads.js$/: worker
   /^lib\/internal\/url\.js$/: whatwg-url
   /^lib\/internal\/modules\/esm/: esm
+  /^lib\/internal\/webstreams/: web streams
+  /^lib\/internal\/test_runner/: dont-land-on-v14.x
 
   # All other lib/ files map directly
   /^lib\/_(\w+)_\w+\.js?$/: $1  # e.g. _(stream)_wrap
@@ -123,6 +125,7 @@ exlusiveLabels:
   /^test\/report\//: test, report
   /^test\/fixtures\/es-module/: test, esm
   /^test\/es-module\//: test, esm
+  /^test\/fixtures\/wpt\/streams//: test, web streams
 
   /^test\//: test
 

.github/workflows/label-flaky-test-issue.yml

@@ -0,0 +1,50 @@
+name: Label Flaky Test Issues
+
+on:
+  issues:
+    types: [opened, labeled]
+
+jobs:
+  label:
+    if: github.event.label.name == 'flaky-test'
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+      - name: Extract labels
+        id: extract-labels
+        env:
+          BODY: ${{ github.event.issue.body }}
+        run: |
+          BODY="${BODY//$'\n'/'\n'}"
+
+          declare -A platform2label
+
+          platform2label["AIX"]="aix";
+          platform2label["FreeBSD"]="freebsd";
+          platform2label["Linux ARM64"]="linux";
+          platform2label["Linux ARMv7"]="arm";
+          platform2label["Linux PPC64LE"]="ppc";
+          platform2label["Linux s390x"]="s390";
+          platform2label["Linux x64"]="linux";
+          platform2label["macOS ARM64"]="macos";
+          platform2label["macOS x64"]="macos";
+          platform2label["SmartOS"]="smartos";
+          platform2label["Windows"]="windows";
+
+          # sed is cleaning up the edges
+          PLATFORMS=$(echo $BODY | sed 's/^.*Platform\\n\\n//' | sed 's/\(, Other\)\?\\n\\n.*$//') 2> /dev/null
+          readarray -d , -t list <<< "$PLATFORMS"
+          labels=
+          for row in "${list[@]}"; do \
+            platform=$(echo $row | xargs); \
+            labels="${labels}${platform2label[$platform]},"; \
+          done;
+
+          echo "::set-output name=LABELS::${labels::-1}"
+
+      - name: Add labels
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          NUMBER: ${{ github.event.issue.number }}
+        run: gh issue edit "$NUMBER" --repo ${{ github.repository }} --add-label "${{ steps.extract-labels.outputs.LABELS }}"

.github/workflows/test-internet.yml

@@ -29,6 +29,7 @@ permissions:
 
 jobs:
   test-internet:
+    if: github.repository == 'nodejs/node' || github.event_name != 'schedule'
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3

.github/workflows/timezone-update.yml

@@ -0,0 +1,55 @@
+name: Timezone update
+on:
+  schedule:
+    # Run once a week at 00:05 AM UTC on Sunday.
+    - cron: 5 0 * * 0
+
+  workflow_dispatch:
+
+permissions:
+  contents: read
+
+jobs:
+  timezone_update:
+    permissions:
+      contents: write  # to push local changes (gr2m/create-or-update-pull-request-action)
+      pull-requests: write  # to create a PR (gr2m/create-or-update-pull-request-action)
+
+    if: github.repository == 'nodejs/node'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout nodejs/node
+        uses: actions/checkout@v3
+        with:
+          persist-credentials: false
+
+      - name: Checkout unicode-org/icu-data
+        uses: actions/checkout@v3
+        with:
+          path: icu-data
+          persist-credentials: false
+          repository: unicode-org/icu-data
+
+      - run: ./tools/update-timezone.mjs
+
+      - name: Open Pull Request
+        uses: gr2m/create-or-update-pull-request-action@6720400cad8e74d7adc64640e4e6ea6748b83d8f  # Create a PR or update the Action's existing PR
+        env:
+          GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+        with:
+          author: Node.js GitHub Bot <github-bot@iojs.org>
+          body: |
+            This PR was generated by tools/timezone-update.yml.
+
+            Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining-icu.md#time-zone-data
+
+            To test, build node off this branch & log the version of tz using
+            ```js
+            console.log(process.versions.tz)
+            ```
+          branch: actions/timezone-update
+          commit-message: 'deps: update timezone'
+          labels: dependencies
+          title: 'deps: update timezone'
+          reviewers: \@nodejs/i18n-api

.mailmap

@@ -137,6 +137,7 @@ David Mark Clements <david.clements@nearform.com> <huperekchuno@googlemail.com>
 David Siegel <david@artcom.de> <david.siegel@artcom.de>
 DC <dcposch@dcpos.ch>
 Deepjyoti Mondal <djmdeveloper060796@gmail.com>
+dnlup <dnlup.dev@gmail.com> <dwon.dnl@gmail.com>
 Domenic Denicola <domenic@domenicdenicola.com>
 Domenic Denicola <domenic@domenicdenicola.com> <d@domenic.me>
 Doug Wade <doug@dougwade.io> <doug.wade@redfin.com>
@@ -287,6 +288,8 @@ Ke Ding <dingkework@hotmail.com>
 Keith M Wesolowski <wesolows@joyent.com> <wesolows@foobazco.org>
 Kelsey Breseman <ifoundthemeaningoflife@gmail.com>
 Kevin Millikin <kmillikin@chromium.org>
+Keyhan Vakil <kvakil@sylph.kvakil.me> <60900335+airtable-keyhanvakil@users.noreply.github.com>
+Keyhan Vakil <kvakil@sylph.kvakil.me> <kvakil@github.kvakil.me>
 Khaidi Chu <i@2333.moe>
 Khaidi Chu <i@2333.moe> <admin@xcoder.in>
 Kimberly Wilber <gcr@sneakygcr.net>
@@ -371,6 +374,7 @@ Nam Nguyen <nam.nguyen@de.ibm.com>
 Nebu Pookins <nebu@nebupookins.net>
 Netto Farah <nettofarah@gmail.com>
 Nicholas Kinsey <pyrotechnick@feistystudios.com>
+Nick Sia <nicholas.sia@vgw.co> <31839263+nicksia-vgw@users.noreply.github.com>
 Nick Soggin <nicksoggin@gmail.com> <iSkore@users.noreply.github.com>
 Nigel Kibodeaux <nigelmail@gmail.com> <nigel@team.about.me>
 Nikola Glavina <glavina.nikola5@gmail.com> <nikola.glavina@student.um.si>
@@ -429,6 +433,8 @@ Ron Korving <ron@ronkorving.nl> <rkorving@wizcorp.jp>
 Ruben Bridgewater <ruben@bridgewater.de> <ruben.bridgewater@fintura.de>
 Ruben Bridgewater <ruben@bridgewater.de> <ruben.bridgewater@maibornwolff.de>
 Russell Dempsey <sgtpooki@gmail.com> <SgtPooki@gmail.com>
+Ruy Adorno <ruyadorno@google.com> <ruyadorno@github.com>
+Ruy Adorno <ruyadorno@google.com> <ruyadorno@hotmail.com>
 Ryan Dahl <ry@tinyclouds.org>
 Ryan Emery <seebees@gmail.com>
 Ryan Mahan <ryanmahan97@gmail.com>

AUTHORS

@@ -1048,7 +1048,7 @@ Joran Siu <joransiu@ca.ibm.com>
 Vitaly Tomilov <vitaly-t@users.noreply.github.com>
 Ratikesh Misra <ratikesh92@gmail.com>
 Alex Perkins <aperkin@rei.com>
-Beth Griggs <bgriggs@redhat.com>
+Beth Griggs <bethanyngriggs@gmail.com>
 Joe Esposito <joe@joeyespo.com>
 Erin Spiceland <yes@erin.codes>
 Ravindra Barthwal <ravindrabarthwal@users.noreply.github.com>
@@ -1784,7 +1784,7 @@ Christopher Sidebottom <chris@damouse.co.uk>
 Edward Andrew Robinson <earobinson@gmail.com>
 Shakeel Mohamed <contact@shakeel.xyz>
 Tobias Kieslich <tobias.kieslich@gmail.com>
-Ruy Adorno <ruyadorno@hotmail.com>
+Ruy Adorno <ruyadorno@google.com>
 Stefania Sharp <stefaniasharp@gmail.com>
 Pawel Golda <pawelgolda@gmail.com>
 Steven Scott <Contact@TheDgtl.net>
@@ -2694,7 +2694,7 @@ Yann Hamon <yann.hamon@contentful.com>
 Ben Swinburne <ben.swinburne@gmail.com>
 Colin Prince <col@colinprince.com>
 TJKoury <TJKoury@gmail.com>
-dnlup <dwon.dnl@gmail.com>
+dnlup <dnlup.dev@gmail.com>
 Hang Jiang <jianghangscu@gmail.com>
 Vladislav Kaminsky <wlodzislav@outlook.com>
 Daiki Ihara <sasurau4@gmail.com>
@@ -3457,7 +3457,7 @@ Yagiz Nizipli <yagiz@nizipli.com>
 liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
 Sergey Nazaryev <sergey@nazaryev.com>
 William Marlow <william.marlow@ibm.com>
-Keyhan Vakil <60900335+airtable-keyhanvakil@users.noreply.github.com>
+Keyhan Vakil <kvakil@sylph.kvakil.me>
 Feng Yu <F3n67u@outlook.com>
 pupilTong <pupiltong@outlook.com>
 rikapo <rikaporori@gmail.com>
@@ -3490,5 +3490,43 @@ John Gee <john@ruru.gen.nz>
 Hrishikesh Kadam <hrkadam.92@gmail.com>
 KrayzeeKev <github@lentinfamily.com>
 Airing <airing@ursb.me>
+jiahao.si <sijiahao0839@gmail.com>
+Rhys <Anemy@users.noreply.github.com>
+Mark S. Miller <erights@users.noreply.github.com>
+Jianru Lin <jianru.lin@gmail.com>
+Lenvin Gonsalves <41874033+98lenvi@users.noreply.github.com>
+Andreu Botella <andreu@andreubotella.com>
+shhh7612 <82669765+shhh7612@users.noreply.github.com>
+Dominic Saadi <dominiceliassaadi@gmail.com>
+ywave620 <60539365+ywave620@users.noreply.github.com>
+NicoNekoru <66227158+NicoNekoru@users.noreply.github.com>
+SADIK KUZU <sadikkuzu@hotmail.com>
+flakey5 <73616808+flakey5@users.noreply.github.com>
+Saurabh Daware <saurabhdaware99@gmail.com>
+BuShe <bushe.cn@icloud.com>
+Nick Sia <nicholas.sia@vgw.co>
+Basit Chonka <baasit121@icloud.com>
+Jeremiah Gowdy <jgowdy@godaddy.com>
+Matthew Peveler <matt.peveler@gmail.com>
+Wing <damianleung@gmail.com>
+Hana <andywangsy@gmail.com>
+Jeff Dickey <216188+jdxcode@users.noreply.github.com>
+Matías Zúñiga <matias.nicolas.zc@gmail.com>
+metonym <ericyl.us@gmail.com>
+Brian Evans <53117772+mrbrianevans@users.noreply.github.com>
+falsandtru <falsandtru@users.noreply.github.com>
+东灯 <43312495+Lampese@users.noreply.github.com>
+Fabian Meyer <3982806+meyfa@users.noreply.github.com>
+StefanStojanovic <StefanStojanovic@users.noreply.github.com>
+Claudio Wunder <cwunder@gnome.org>
+Shrujal Shah <shrujalshah@hotmail.com>
+Taha-Chaudhry <46199675+Taha-Chaudhry@users.noreply.github.com>
+smitley <brandon.smitley@gmail.com>
+Brian Muenzenmeyer <Brian.Muenzenmeyer@target.com>
+sidwebworks <xodedeveloper@gmail.com>
+Connor Burton <me@connorburton.com>
+chexiongsheng <chexiongsheng@qq.com>
+Lucas Santos <lhs.santoss@gmail.com>
+“Pooja <pakcutie14@gmail.com>
 
 # Generated by tools/update-authors.mjs

BUILDING.md

@@ -37,7 +37,7 @@ file a new issue.
       * [Option 1: Manual install](#option-1-manual-install)
       * [Option 2: Automated install with Boxstarter](#option-2-automated-install-with-boxstarter)
     * [Building Node.js](#building-nodejs-2)
-  * [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os)
+  * [Android](#android)
 * [`Intl` (ECMA-402) support](#intl-ecma-402-support)
   * [Build with full ICU support (all locales supported by ICU)](#build-with-full-icu-support-all-locales-supported-by-icu)
     * [Unix/macOS](#unixmacos)
@@ -633,6 +633,7 @@ Set-ExecutionPolicy Unrestricted -Force
 iex ((New-Object System.Net.WebClient).DownloadString('https://boxstarter.org/bootstrapper.ps1'))
 get-boxstarter -Force
 Install-BoxstarterPackage https://raw.githubusercontent.com/nodejs/node/HEAD/tools/bootstrap/windows_boxstarter -DisableReboots
+refreshenv
 ```
 
 The entire installation using Boxstarter will take up approximately 10 GB of
@@ -659,22 +660,25 @@ To test if Node.js was built correctly:
 > Release\node -e "console.log('Hello from Node.js', process.version)"
 ```
 
-### Android/Android-based devices (e.g. Firefox OS)
+### Android
 
 Android is not a supported platform. Patches to improve the Android build are
 welcome. There is no testing on Android in the current continuous integration
 environment. The participation of people dedicated and determined to improve
 Android building, testing, and support is encouraged.
 
 Be sure you have downloaded and extracted
-[Android NDK](https://developer.android.com/tools/sdk/ndk/index.html) before in
+[Android NDK](https://developer.android.com/ndk) before in
 a folder. Then run:
 
 ```console
-$ ./android-configure /path/to/your/android-ndk
-$ make
+$ source ./android-configure /path/to/your/android-ndk target_arch android_sdk_version
+$ make -j4
 ```
 
+The Android SDK version should be at least 24 (Android 7.0) and the target
+architecture supports \[arm, arm64/aarch64, x86, x86\_64].
+
 ## `Intl` (ECMA-402) support
 
 [Intl](https://github.com/nodejs/node/blob/HEAD/doc/api/intl.md) support is

LICENSE

@@ -55,7 +55,7 @@ The externally maintained libraries used by Node.js are:
   """
     MIT License
 
-    Copyright (C) 2012-2020 by various contributors (see AUTHORS)
+    Copyright (C) 2012-2022 by various contributors (see AUTHORS)
 
     Permission is hereby granted, free of charge, to any person obtaining a copy
     of this software and associated documentation files (the "Software"), to deal
@@ -1713,3 +1713,35 @@ The externally maintained libraries used by Node.js are:
     OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
      ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
   """
+
+- base64, located at deps/base64/base64/, is licensed as follows:
+  """
+    Copyright (c) 2005-2007, Nick Galbreath
+    Copyright (c) 2013-2019, Alfred Klomp
+    Copyright (c) 2015-2017, Wojciech Mula
+    Copyright (c) 2016-2017, Matthieu Darbois
+    All rights reserved.
+
+    Redistribution and use in source and binary forms, with or without
+    modification, are permitted provided that the following conditions are
+    met:
+
+    - Redistributions of source code must retain the above copyright notice,
+      this list of conditions and the following disclaimer.
+
+    - Redistributions in binary form must reproduce the above copyright
+      notice, this list of conditions and the following disclaimer in the
+      documentation and/or other materials provided with the distribution.
+
+    THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
+    IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED
+    TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
+    PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+    HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+    SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED
+    TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+    PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
+    LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
+    NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
+    SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+  """

Makefile

@@ -115,6 +115,7 @@ $(NODE_EXE) $(NODE_G_EXE): config.gypi out/Makefile
 	  ln -fs out/${build_type}/$(NODE_EXE) $@; fi
 else
 ifeq ($(BUILD_WITH), ninja)
+NINJA ?= ninja
 ifeq ($(V),1)
 	NINJA_ARGS := $(NINJA_ARGS) -v
 endif
@@ -124,11 +125,11 @@ else
 	NINJA_ARGS := $(NINJA_ARGS) $(filter -j%,$(MAKEFLAGS))
 endif
 $(NODE_EXE): config.gypi out/Release/build.ninja
-	ninja -C out/Release $(NINJA_ARGS)
+	$(NINJA) -C out/Release $(NINJA_ARGS)
 	if [ ! -r $@ ] || [ ! -L $@ ]; then ln -fs out/Release/$(NODE_EXE) $@; fi
 
 $(NODE_G_EXE): config.gypi out/Debug/build.ninja
-	ninja -C out/Debug $(NINJA_ARGS)
+	$(NINJA) -C out/Debug $(NINJA_ARGS)
 	if [ ! -r $@ ] || [ ! -L $@ ]; then ln -fs out/Debug/$(NODE_EXE) $@; fi
 else
 $(NODE_EXE) $(NODE_G_EXE):