Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: remove _readableState from debug statement #45063

Merged
merged 1 commit into from
Oct 21, 2022
Merged

net: remove _readableState from debug statement #45063

merged 1 commit into from
Oct 21, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 19, 2022

Ref: #445

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Oct 19, 2022
@Trott Trott added the stream Issues and PRs related to the stream subsystem. label Oct 19, 2022
@Trott
Copy link
Member Author

Trott commented Oct 19, 2022

@nodejs/streams

@Trott Trott changed the title net: remove _readableStream from debug statement net: remove _readableState from debug statement Oct 19, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 19, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47329/

mcollina
mcollina approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 19, 2022
ShogunPanda
ShogunPanda approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47353/

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit b86b1a7 into nodejs:main Oct 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b86b1a7

@Trott Trott deleted the net-readablestream branch October 21, 2022 22:19
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@Trott @RafaelGSS
net: remove _readableState from debug statement
6c20fa5 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@Trott @RafaelGSS
net: remove _readableState from debug statement
36acf8a 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
net: remove _readableState from debug statement
1445b35 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@Trott @danielleadams
net: remove _readableState from debug statement
8cc29a3 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@Trott @danielleadams
net: remove _readableState from debug statement
e4f7bcf 
Ref: #445
PR-URL: #45063
Refs: #445
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JungMinu JungMinu JungMinu approved these changes

@jasnell jasnell jasnell approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @mcollina @ShogunPanda @jasnell @JungMinu